Find some "global variables" are missing to define into the WordPress core files.

[viralsampat]

Hello team,

I have checked WordPress core file and I have found this "Overriding WordPress globals is prohibited." errors into the few files.

Also, I have found that some variables need to define globally into the few core files.

Here, I have mentioned few files list:

/src/wp-admin/menu-header.php
/src/wp-admin/menu.php
/src/wp-includes/shortcodes.php
/src/wp-includes/version.php

Thanks,

[viralsampat]

I have checked above mentioned issue and I have resolved it and added patch.

[mukesh27]

@viralsampat Your attached 62984.patch​ patch shows wrong version 6.2-alpha-54642-src

[audrasjb]

I concur, the patch doesn't apply to current trunk branch.

[johnbillion]

The variables in version.php are not always globals, the documentation is somewhat misleading. They're global when version.php is included in the global scope, but it also gets included in local scope during the upgrade process.

Explicitly declaring version.php variables as global will break updates. If someone wants to open a PR with this change, fingers crossed it gets picked up by tests. If not, the tests need improving.

Trac ticket: ​http://core.trac.wordpress.org/ticket/62984