Fix layout support classes to be generated with a stable ID

[darerodz]

This ticket tracks the merging of PHP files for the following Gutenberg changes:

​https://github.com/WordPress/gutenberg/pull/68210

This fixes a bug reported in ​https://github.com/WordPress/gutenberg/issues/67308 related to the Interactivity API's client-side navigation feature, which these layout classes affect. There was a previous attempt at https://core.trac.wordpress.org/ticket/59681 to solve the issue, but it was insufficient.

This is a backport PR for WordPress 6.9 that includes the following PHP Gutenberg changes:

• ​https://github.com/WordPress/gutenberg/pull/68210

Trac ticket: https://core.trac.wordpress.org/ticket/62985

[joemcgill]

I'm adding this to the 6.8 milestone for consideration. @fabiankaegy and @Mamaduka could one of you confirm that the current PR addresses the issue reported in the GB repo?

For anyone else wanting to test this, reproduction steps can be found in ​https://github.com/WordPress/gutenberg/issues/67308.

Thanks, @joemcgill, for your review. 🙏

I'm adding tests for the wp_unique_id_from_values() function. They should be ready before these changes are merged.

@joemcgill, I just added PHPUnit tests for wp_unique_id_from_values() if you want to take a look.

[joemcgill]

In 60038:

Editor: Fix layout support classes to be generated with a stable ID.

This fixes a bug reported in ​https://github.com/WordPress/gutenberg/issues/67308 related to the Interactivity API's client-side navigation feature by replacing the incrementally generated IDs with stable hashes derived from the block's layout style definition.

Fixes #62985.
Props darerodz.

[luisherranz]

Thanks @joemcgill!

[peterwilsoncc]

Reopening this as the wp_unique_id_from_values() function includes an odd _doing_it_wrong() call.

• There's an unused sprintf in the message as there is no placeholder
• The empty( $data ) seems a little weird with the function signature wp_unique_id_from_values( array $data, string $prefix = '' ): string, as PHP will fatal if nothing/an incorrect type is passed, and getting a signature for an empty array while weird, seems like it could potentially be useful.

Edit: ​PR created for the first item, but thinking about it further I'm not sure it needs to be type strict at all. wp_unique_id_from_values( 'some string or type' ) could be potentially useful.

A little tidy up of the DIW call within wp_unique_id_from_values():

• Remove the unused sprintf
• Figure whether the DIW should be used.

Trac ticket: https://core.trac.wordpress.org/ticket/62985

[peterwilsoncc]

In 60075:

Editor: Tidy up _doing_it_wrong() call in wp_unique_id_from_values().

Adds a translator note not to translate the parameter name $data and removes an unused sprintf() that doesn't contain any placeholders.

Props peterwilsoncc, joemcgill.
Fixes #62985.

[joemcgill]

In 60079:

Editor: Fix translators note in wp_unique_id_from_values().

Follow up to [60075] to fix a typo.

Props mukesh27, johnbillion.
See #62985.

[darerodz]

Thanks, folks, for taking care of this!

[swissspidy]

This should use sprintf with a placeholder for the $data part.

https://core.trac.wordpress.org/ticket/62985

[audrasjb]

Self assigning for a quick follow-up fix (see the above PR).

[audrasjb]

In 60085:

Coding Standards: Use sprintf() for correct i18n in wp_unique_id_from_values().

Follow-up to [60075], [60079].

Fixes #62985.

[desrosj]

Just noting that [60038] is causing some ​failures in test reports from hosts. #63175 has been opened to follow up.