WordPress.org
Get WordPress

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #62985, comment 8


Ignore:
Timestamp:
03/23/2025 10:12:31 PM (3 months ago)
Author:
peterwilsoncc
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #62985, comment 8

    initial v1  
    33* There's an unused `sprintf` in the message as there is no placeholder
    44* The `empty( $data )` seems a little weird with the function signature `wp_unique_id_from_values( array $data, string $prefix = '' ): string`, as PHP will fatal if nothing/an incorrect type is passed, and getting a signature for an empty array while weird, seems like it could potentially be useful.
     5
     6Edit: [https://github.com/WordPress/wordpress-develop/pull/8570 PR created for the first item], but thinking about it further I'm not sure it needs to be type strict at all. `wp_unique_id_from_values( 'some string or type' )` could be potentially useful.