WordPress.org
Get WordPress

Make WordPress Core

Opened 4 months ago

Closed 4 months ago

#63003 closed enhancement (fixed)

Simplify file name generation for image conversions.

Reported by: joedolson's profile joedolson Owned by: joedolson's profile joedolson
Milestone: 6.8 Priority: normal
Severity: normal Version: 6.7
Component: Media Keywords: has-patch commit
Focuses: Cc:

Description

Following [59855], it's possible to pass an empty string to generate a filename without a suffix. This allows us to simplify the code previously added in [59379].

Attachments (1)

63003.diff​ (1.2 KB) - added by joedolson 4 months ago.

Download all attachments as: .zip

Change History (6)

@joedolson
4 months ago

#1 @joedolson
4 months ago

  • Keywords has-patch added

It's not strictly necessary to add this in 6.8, but it makes sense, and is a simple change.

This ticket was mentioned in ​Slack in #core by audrasjb. ​View the logs.
4 months ago

#3 @audrasjb
4 months ago

The patch looks good to me.
@joedolson the deadline for 6.8 enhancement in on Monday 3 :)

#4 @joedolson
4 months ago

  • Keywords commit added

#5 @joedolson
4 months ago

  • Owner set to joedolson
  • Resolution set to fixed
  • Status changed from new to closed

In 59897:

Media: Simplify file name generation for image conversions.

Use the empty string argument in $editor->save() added in [59855] to simplify the code used to prevent image format conversions from getting a suffix appended to their file names.

Props joedolson, audrasjb, azaozz.
See #62385.
Fixes #63003.

Note: See TracTickets for help on using tickets.