Replacing certain bulk-edit fields blocks all bulk edits

[ethitter]

In r59134, validation was added to prevent users from submitting bulk edits if no items are selected, or if no change is chosen for the selected items. As part of the validation, a specific input name is expected for the new value. The input name cannot be customized.

If, for example, the "Change role to..." dropdown on the WP_Users_List_Table is removed, validation for all other bulk actions will fail because the validation requires an input named new_role. I encountered this when replacing the default dropdown with a multi-select to support Core's ability for users to have multiple roles. I was able to work around this issue by including a hidden input with the expected name, but that defeats the validation.

If the input names could be modified, the validation would support custom input names without requiring extra, unused hidden fields; developers would also not need to implement their own client-side validation. Currently, the input names are hardcoded in the validation JS, but they could be passed via localization after being filtered.

[kabir93]

Attached 63005.alternative.diff as an alternative approach. This patch: - Adds a filterable bulk_edit_input_name in WP_Users_List_Table with a context parameter for flexibility. - Localizes the input name to BulkEditSettings in user.js, keeping the solution specific to the Users screen. - Avoids modifying common.js, reducing the risk of side effects on other list tables. Compared to 63005.diff, this offers a more targeted fix, simpler maintenance, and a reusable filter design. It assumes a follow-up change in user.js to use BulkEditSettings.inputName (not included here but can be provided). Feedback welcome!

[jorbin]

cc @joedolson - This relates to the work you did in 6.7

While I don't think this should be trigger a 6.7 minor in and of itself, I think that depending on the fix, this could make sense to backport to the 6.7 branch.

[joedolson]

@jorbin If there's any likelihood we'll have an additional minor for 6.7, then it probably does make sense to backport.

@kabir93 I think it would make sense to add in the additional change in user.js; I don't see a lot of value in separating those into two separate commits.

[jorbin]

I think the approach in 63005.diff makes a little more sense to me since the fix isn't limited to the user table and could provide flexibility to the posts screen as well.

@joedolson My gut says it's highly unlikely that there would be an additional minor while 6.7 is the supported version, but I also think that having things tested and ready in the branch makes it easier if we decide to do one.

[joedolson]

Makes sense to me to go with the simpler version.

@ethitter The patch looks good in principle, but I think we could do this in a single filter by filtering the whole array, and I think that would be preferable - I don't think it would be a common scenario where somebody would only want to change one of the parameters, so they might as well be filtered together.

We'll also need a doc block for the filter.

This updates the patch from @ethitter to include inline documentation and a single filter

https://core.trac.wordpress.org/ticket/63005

[desrosj]

Since 6.8 is imminent, going to punt this to 6.8.1 as no 6.7.3 is planned at this time.

[joedolson]

This is looking good; marking for commit.

[joedolson]

In 60186:

Themes: Add filter on bulk action fields.

Because validation was added in [59134] to prevent submitting bulk actions with no selected action, sites that remove or change the default bulk actions can fail due to the missing required inputs. Add a filter (bulk_action_observer_ids) that allows modifying the actions accepted to fulfill validation rules.

Props ethitter, kabir93, jorbin, davidbaumwald, joedolson.
Fixes #63005.

[joedolson]

@jorbin Committed to trunk; passing to you for review and backport.

[jorbin]

In 60188:

Themes: Add filter on bulk action fields.

Because validation was added in [59134] to prevent submitting bulk actions with no selected action, sites that remove or change the default bulk actions can fail due to the missing required inputs. Add a filter (bulk_action_observer_ids) that allows modifying the actions accepted to fulfill validation rules.

Reviewed by Jorbin.
Merges [60186] to the 6.8 branch.

Props ethitter, kabir93, jorbin, davidbaumwald, joedolson.
Fixes #63005.