Performance Tests: "before" checks fail on older PRs

[joemcgill]

The Performance workflow includes a job for testing the performance of the previous commit in order to show the performance impact of the change compared to the latest commit prior to the change.

This can fail on the "Download previous build artifact (target branch or previous commit)" step if the PR is old enough that the Artifact has expired.

Ideally, PRs should test trunk against the current PR when applied to trunk, but if that is not easily possible, the tests should be able to create a new build from the prior state whenever the build artifact has expired.

These were recently changed in [59749] which may be where this issue was introduced.

[swissspidy]

Wouldn't be easier to just merge trunk into the branches to make them up-to-date again?

[johnbillion]

This affects any PR with a base branch that is more than 90 days old, which is the retention period for artifacts. We could add support for re-generating the build in this situation, but I also agree with @swissspidy that a PR with a base that's more than 90 days old should be rebased or have trunk merged into it regardless. This would be nice to fix but I don't think it's strictly necessary.

[desrosj]

Although this is a CI related change, I'm going to punt it for now with a close suggestion. I do agree with the sentiment around merging trunk into the branch after the 90 day artifact lifespan. It's a nice reminder to update your branch if someone has forgotten to.

[flixos90]

Based on the previous feedback, I'm going to close this. Given the ability and best practice to refresh a PR with latest trunk, I don't think it's worth the effort.