Incorrect type for the $public parameter in 'robots_txt' filter

[SergeyBiryukov]

In the robots_txt filter, the $public parameter is documented as bool. However, in practice it's a string, either '0' or '1', retrieved from get_option( 'blog_public' ).

We should either cast the value to bool for the filter, to match the documented type, or correct the documentation.

[shailu25]

Patch Added.

[shailu25]

Added Alternative Patch.

https://core.trac.wordpress.org/ticket/63039

[kapilpaul]

Since we are already checking $public as a boolean in other functions, it makes more sense to cast it to bool before passing it to the filter. This ensures consistency, prevents potential type issues, and aligns with the documented type. Updating the documentation instead of casting might introduce inconsistencies in how we handle this value across different functions.

[audrasjb]

Yes, sounds better to cas it to bool.
Self assigning for commit.

[audrasjb]

In 59946:

General: Cast $public param to bool in do_robots().

This changeset properly casts the $public variable into bool in do_robots() for better consistency between code and docs.

Props SergeyBiryukov, shailu25, kapilpaul.
Fixes #63039.