Make WordPress Core

Opened 12 days ago

Closed 7 days ago

#63052 closed defect (bug) (fixed)

Extension check during upgrade does not work on WordPress prior to 5.1

Reported by: johnbillion's profile johnbillion Owned by: johnbillion's profile johnbillion
Milestone: 6.8 Priority: normal
Severity: major Version: trunk
Component: Upgrade/Install Keywords: has-patch
Focuses: Cc:

Description

As discovered by the upgrade checks for 6.8 beta 1, the check for missing required extensions during the upgrade process that were added in [59803] calls the WP_Error::has_errors() method which was introduced in WordPress 5.1. This means sites running WordPress prior to 5.1 will experience a fatal during the upgrade process.

The site will remain online and functional, but it won't be possible to proceed with the upgrade.

Example failing workflow: https://github.com/WordPress/wordpress-develop/actions/runs/13657290367/job/38180581900

Change History (6)

This ticket was mentioned in Slack in #core by jeffpaul. View the logs.


12 days ago

This ticket was mentioned in PR #8457 on WordPress/wordpress-develop by @johnbillion.


12 days ago
#2

  • Keywords has-patch added; needs-patch removed

Trac ticket: https://core.trac.wordpress.org/ticket/63052

I've added a develop upgrade check for WordPress 5.0 too, but we might need to exclude this from running on PHP 8.4. Let's see what the tests tell us.

This ticket was mentioned in Slack in #cli by swissspidy. View the logs.


11 days ago

This ticket was mentioned in Slack in #core by benjamin_zekavica. View the logs.


11 days ago

#6 @johnbillion
7 days ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 59956:

Upgrade/Install: Adjust the check for missing extensions during an upgrade so it remains compatible with versions of WordPress prior to 5.1.

The WP_Error::has_errors() method was introduced in WordPress 5.1, so this change uses its internal logic instead to remain compatible with earlier versions.

Props swissspidy, joemcgill, desrosj.

Fixes #63052

Note: See TracTickets for help on using tickets.