JS Warning in navigation menus when removing an item

[joedolson]

When removing an item from nav menus, an uncaught TypeError is thrown: "menus.updateParentDropdown is not a function". Thrown by the removeMenuItem method, where it appears that the function is attached to the wrong object.

Introduced in [59265].

Milestoning for 6.7.3 if that occurs.

[abcd95]

Hi @joedolson and thanks for reporting this issue.

I think the problem occurs because, in nav-menu.js, the code is incorrectly calling the updateParentDropdown() and updateOrderDropdown() methods on the menus object instead of on the proper jQuery object.

See here -

https://core.trac.wordpress.org/browser/trunk/src/js/_enqueues/lib/nav-menu.js#L1765
https://core.trac.wordpress.org/browser/trunk/src/js/_enqueues/lib/nav-menu.js#L1224

The fix is straightforward - we need to call these methods on the menu container object ($( '#menu-to-edit' ))

I'll submit a PR with this fix shortly which in my testing resolves the console errors.

Trac ticket:

Thanks, I tested the patch on my side and I can confirm it fixes the issue.

[joedolson]

Thanks for the quick action, @abcd95! LGTM.

[joedolson]

In 59950:

Menus: Fix JS Warning when removing menu items.

Move the updateParentDropdown and updateOrderDropdown methods to be called on the jQuery menu object instead of on the menus translations object.

Props joedolson, abcd95, audrasjb.
Fixes #63059.

[joedolson]

Re-opening for 6.7.3, although that seems like a low probability milestone at this point.

[jorbin]

In 59977:

Menus: Fix JS Warning when removing menu items.

Move the updateParentDropdown and updateOrderDropdown methods to be called on the jQuery menu object instead of on the menus translations object.

Reviewed by jorbin.
Merges [59950] to the 6.7 branch.

Props joedolson, abcd95, audrasjb.
Fixes #63059.

[phanduynam]

Is the issue resolved? If so, please close it.

[jorbin]

@phanduynam The status is right next to the ticket number at the top of the page. This has been closed for 5 weeks.

[phanduynam]

@jorbin closed but why do I still see it here?
https://core.trac.wordpress.org/tickets/minor

[Presskopp]

.. because of the milestone, here you can see it's closed, but still marked as 6.7.3: https://core.trac.wordpress.org/milestone/6.7.3

[joedolson]

Moving to the 6.8 milestone, which is where it actually shipped.