WordPress.org
Get WordPress

Make WordPress Core

Opened 20 months ago

Closed 16 months ago

#63073 closed defect (bug) (fixed)

Twenty Twelve: theme's figcaption styles do not apply in the editor

Reported by: nidhidhandhukiya Owned by: karmatosed
Priority: normal Milestone: 6.8.2
Component: Bundled Theme Version: 5.8
Severity: normal Keywords: has-patch
Cc: Focuses: css

Description

Steps to reproduce the issue.

  1. Activate Twenty twelve theme.
  2. Choose table block.
  3. Add some text and caption.
  4. Now check that in editor and front end.

Caption in table is aligned center in editor but aligned left in the front end which is not looking good.

Attachments (2)

63073.patch​ (420 bytes ) - added by nidhidhandhukiya 20 months ago.
63073.1.patch​ (855 bytes ) - added by sabernhardt 20 months ago.
adjusts editor-blocks to reflect theme's figcaption styles with the revised class order, using text-align: start to work around the missing .rtl class within the iframe

Download all attachments as: .zip

Change History (11)

@nidhidhandhukiya
20 months ago

@sabernhardt
20 months ago

adjusts editor-blocks to reflect theme's figcaption styles with the revised class order, using text-align: start to work around the missing .rtl class within the iframe

#1 @sabernhardt
20 months ago

  • Focuses css added
  • Keywords has-patch added
  • Milestone Awaiting Review → 6.9
  • Summary Twenty twelve table block having issue in caption alignment. → Twenty Twelve: theme's figcaption styles do not apply in the editor
  • Version → 5.8

Similar to #58539, the discrepancy can happen with any figcaption for blocks (including Image, Video, Embed and Table).

Twenty Twelve specified left alignment and other styles for the front end, and the editor styles should honor those again by accounting for classes before the one that begins with wp-block-.

#2 @karmatosed
16 months ago

  • Keywords commit added
  • Milestone 6.9 → 6.8.2
  • Owner set to karmatosed
  • Status new → assigned

Thank you everyone. I am going to assign to myself to test and see about getting this into a commit.

#3 @karmatosed
16 months ago

  • Resolution → fixed
  • Status assigned → closed

In 60343:

Twenty Twelve: Fixes figcaption alignment.

The figcaption alignment was not the same on the front as in the editor. This resolves that.

Props nidhidhandhukiya, sabernhardt.
Fixes #63073.

#4 @sabernhardt
16 months ago

  • Keywords commit removed

Reopening for backport consideration.

#5 @sabernhardt
16 months ago

  • Resolution fixed
  • Status closed → reopened

Reopening for backport consideration (for real this time).

This ticket was mentioned in ​Slack in #core by zunaid321. ​View the logs.
16 months ago

This ticket was mentioned in ​Slack in #core-themes by sabernhardt. ​View the logs.
16 months ago

This ticket was mentioned in ​Slack in #core by audrasjb. ​View the logs.
16 months ago

#9 @audrasjb
16 months ago

  • Resolution → fixed
  • Status reopened → closed

In 60427:

Twenty Twelve: Fixes figcaption alignment.

The figcaption alignment was not the same on the front as in the editor. This resolves that.

Reviewed by audrasjb, karmatosed.
Merges [60343] to the 6.8 branch.
Props nidhidhandhukiya, sabernhardt.
Fixes #63073.

Note: See TracTickets for help on using tickets.