Phpunit test failure due to US daylight saving time

[audrasjb]

The test_wp_timezone_override_offset phpunit test is currently failing due to US daylight saving time.

[audrasjb]

Test failure:

Tests_Functions_wpTimezoneOverrideOffset::test_wp_timezone_override_offset with data set "NST option set" ('America/St_Johns', -3.5)
Failed asserting that -2.5 is identical to -3.5.

[audrasjb]

Related: #59980

Introduced in [59931].

Trac Ticke: Core-63079

### Summary

• This PR fixes the failing test for wp_timezone_override_offset(), caused by Daylight Saving Time (DST) adjustments in America/St_Johns. The test previously expected a static -3.5 offset, but during DST, the actual offset is -2.5, leading to failures.

### Changes

• Introduced get_expected_offset() to dynamically determine the correct offset.

• Updated the test data provider to use this function instead of a hardcoded value.

I think a better approach would be something along the lines of: if the America/St_Johns timezone is currently observing DST then the expected value is -2.5, else the expected value is -3.5. What do you think?

Yes, nice idea, sounds good to me 👍

Hi @johnbillion , It makes sense, thanks for the review and feedback. I have updated the implementation, can you please check once. Assigning your for re-review.

[johnbillion]

In 59959:

Date/Time: Fix the recently introduced test for wp_timezone_override_offset() which failed to take into consideration daylight saving time for the America/St_Johns timezone.

Props debarghyabanerjee, johnbillion, mukesh27, audrasjb.

Fixes #63079

This was committed in https://core.trac.wordpress.org/changeset/59959 . Thanks everyone!

This was committed in https://core.trac.wordpress.org/changeset/59959 . Thanks everyone!