Make WordPress Core

Opened 6 weeks ago

#63083 new defect (bug)

Fail tests making external HTTP requests that are not in the `external-http` group.

Reported by: peterwilsoncc's profile peterwilsoncc Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version:
Component: Build/Test Tools Keywords:
Focuses: Cc:

Description

While reviewing the patch for #62325, I decided it would be helpful to have two tests:

  • Ensure that any test making an external HTTP request was in the group external-http
  • Ensure that any test in the external-http group did, in fact, make a request

I did this in the hackiest way possible (see the attachment) for the purposes of getting the review done but I am wondering if it's worth adding such tests to the test suite to ensure that HTTP connection errors don't affect the main test suite.

I'm not sure if it's a good or bad idea but would appreciate others weighing in with their views.

Attachments (1)

hack.diff (1.5 KB) - added by peterwilsoncc 6 weeks ago.

Download all attachments as: .zip

Change History (1)

@peterwilsoncc
6 weeks ago

Note: See TracTickets for help on using tickets.