Opened 17 months ago
#63083 new defect (bug)
Fail tests making external HTTP requests that are not in the `external-http` group.
| Reported by: | peterwilsoncc | Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | Awaiting Review |
| Component: | Build/Test Tools | Version: | |
| Severity: | normal | Keywords: | |
| Cc: | Focuses: |
Description
While reviewing the patch for #62325, I decided it would be helpful to have two tests:
- Ensure that any test making an external HTTP request was in the group
external-http - Ensure that any test in the
external-httpgroup did, in fact, make a request
I did this in the hackiest way possible (see the attachment) for the purposes of getting the review done but I am wondering if it's worth adding such tests to the test suite to ensure that HTTP connection errors don't affect the main test suite.
I'm not sure if it's a good or bad idea but would appreciate others weighing in with their views.
Attachments (1)
Note:
See TracTickets
for help on using tickets.
![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png)