Make WordPress Core

Opened 7 weeks ago

Closed 6 weeks ago

Last modified 5 weeks ago

#63084 closed defect (bug) (fixed)

Screen reader shortcut hidden in block editor on smaller screens

Reported by: sabernhardt's profile sabernhardt Owned by: joedolson's profile joedolson
Milestone: 6.8 Priority: normal
Severity: normal Version: 5.8
Component: Editor Keywords: has-patch has-testing-info commit
Focuses: accessibility, css Cc:

Description

In the viewport range between 600 and 782 pixels, skip links are mostly hidden due to overflow-y: auto in the block editor (GB28959).

Attachments (4)

before-patch-admin-menu-showing.png (46.4 KB) - added by narenin 7 weeks ago.
Before patch (with admin menu showing)
after-patch-admin-menu-showing.png (51.3 KB) - added by narenin 7 weeks ago.
After patch (with admin menu showing)
before-patch-fullscreen-mode.png (42.7 KB) - added by narenin 7 weeks ago.
Before patch (Fullscreen Mode)
after-patch-fullscreen-mode.png (46.2 KB) - added by narenin 7 weeks ago.
After patch (Fullscreen Mode)

Download all attachments as: .zip

Change History (16)

This ticket was mentioned in PR #8493 on WordPress/wordpress-develop by @sabernhardt.


7 weeks ago
#1

  • Keywords has-patch added

Changes the top value to a positive 7 pixels at the (max-width: 782px) breakpoint within the block editor. With a negative value, it was mostly hidden.

I edited common.css instead of the edit-post styles because I did not want to redefine the negative value at (min-width: 782px).

Before patch, with admin menu showing

https://github.com/user-attachments/assets/1ac67689-2c4d-4960-a66b-8985b409c2ef

With patch, with admin menu showing

https://github.com/user-attachments/assets/5117924c-fbd4-42c6-af48-a83d25d8e44d

Before patch, in Fullscreen mode

https://github.com/user-attachments/assets/611b0628-1065-4b14-bae3-2927931b2708

With patch, in Fullscreen mode

https://github.com/user-attachments/assets/a54b2b46-6561-4445-a8b3-dff6c86a2e3c

Trac 63084

#2 @narenin
7 weeks ago

Test Report

This report validates that the indicated patch addresses the issue.

Patch tested:

https://github.com/WordPress/wordpress-develop/pull/8493

Environment

OS: macOS 14.6.1
Web Server: PHP.wasm
PHP: 7.4.31-dev
WordPress: 6.8-beta-2
Browser: Chrome Version 133.0.6943.142
Theme: Minimal Child Theme Version 1.0.2

Actual Results

✅ Issue resolved with patch.

@narenin
7 weeks ago

Before patch (with admin menu showing)

@narenin
7 weeks ago

After patch (with admin menu showing)

@narenin
7 weeks ago

Before patch (Fullscreen Mode)

@narenin
7 weeks ago

After patch (Fullscreen Mode)

#3 @narenin
7 weeks ago

  • Keywords has-testing-info added

#4 @joedolson
7 weeks ago

  • Milestone changed from Awaiting Review to 6.8
  • Owner set to joedolson
  • Status changed from new to accepted

It's relatively late in 6.8 to be milestoning this, but I think that the intersection of risk to benefit here justifies it.

@audrasjb commented on PR #8493:


7 weeks ago
#5

The patch tests well on my side. This new ticket is good to ship during 6.8 beta cycle.

#6 @audrasjb
7 weeks ago

Yes I agree this bugfix looks ready to ship during beta cycle.

@mukesh27 commented on PR #8493:


7 weeks ago
#7

The dashboard have similar issue for smaller screen. Do we needs to open separate ticket for that?

https://github.com/user-attachments/assets/34b5e18e-38d4-4180-a185-a38fb839fbc5

@sabernhardt commented on PR #8493:


7 weeks ago
#8

The Dashboard intentionally has the shortcut link above the admin toolbar (that's why it has a negative margin of 7 pixels minus the toolbar height).

The bug is when the block editor clips the shortcut link(s). If another screen clips it, we could _consider_ changing the negative margins to 7px at any screen width instead.

#10 @joedolson
6 weeks ago

  • Keywords commit added

I think this is good to go; the issue on the dashboard is quite different, as there's no clipping.

#11 @joedolson
6 weeks ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 59992:

Editor: A11y: Skip link hidden in editor on medium-small screens.

Adjust the position of the skip link in viewports between 600 and 782 pixels, where they were hidden due to overflow-y: auto in the block editor. Ensures that the skip link is visibly available for users on all viewport sizes.

Props sabernhardt, narenin, audrasjb, mukesh27, joedolson, wildworks.
Fixes #63084.

@sabernhardt commented on PR #8493:


5 weeks ago
#12

Committed in r59992

Note: See TracTickets for help on using tickets.