WordPress.org
Get WordPress

Make WordPress Core

Opened 2 months ago

Closed 2 months ago

Last modified 2 months ago

#63097 closed defect (bug) (invalid)

Remaining "noopener" from function column_author() output

Reported by: eddystile's profile eddystile Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Comments Keywords: has-patch has-unit-tests
Focuses: administration Cc:

Description

Introduced in [52061].

We should remove "noopener" from :

class-wp-comments-list-table.php

Since this was introduced, supported browsers have changed their security policies and no longer allow the opened link to have JavaScript access to the previous tab.

To easily reproduce the issue:

  • create a new comment with website url
  • In admin on comments page check comment's user website link
  • Confirm that the link has a noopener attribute

Attachments (1)

noopener_comment.png​ (119.6 KB) - added by eddystile 2 months ago.
noopener attribute in url user comment

Download all attachments as: .zip

Change History (6)

@eddystile
2 months ago

noopener attribute in url user comment

#1 @audrasjb
2 months ago

  • Component changed from General to Administration
  • Version 5.9 deleted

#2 @audrasjb
2 months ago

  • Summary changed from Remaining "noopener" from function column_author() outpu to Remaining "noopener" from function column_author() output

#3 follow-up: @sabernhardt
2 months ago

  • Component changed from Administration to Comments
  • Focuses administration added
  • Milestone Awaiting Review deleted
  • Resolution set to invalid
  • Status changed from new to closed

[52007] added the rel values with #40916, and #53843 intentionally retained them in this case.

The comment author links do not open in a new tab automatically, so browsers would not follow the noopener behavior without specifying it.

#4 in reply to: ↑ 3 @eddystile
2 months ago

Ok !
My bad.
Thank you @sabernhardt

Replying to sabernhardt:

[52007] added the rel values with #40916, and #53843 intentionally retained them in this case.

The comment author links do not open in a new tab automatically, so browsers would not follow the noopener behavior without specifying it.

This ticket was mentioned in ​PR #8506 on ​WordPress/wordpress-develop by ​@rvouill.
2 months ago #5

  • Keywords has-patch has-unit-tests added

https://core.trac.wordpress.org/ticket/63097

Note: See TracTickets for help on using tickets.