Make WordPress Core

#63117 closed defect (bug) (fixed)

Stop installing Playwright browsers in old branches

Reported by: desrosj's profile desrosj Owned by: desrosj's profile desrosj
Milestone: 6.8 Priority: normal
Severity: normal Version:
Component: Build/Test Tools Keywords: has-patch
Focuses: Cc:

Description

In 6.4, the E2E tests switched to using Playwright. Earlier branches continue to utilize Puppeteer (see [56926]).

Recently, the E2E testing workflow in 6.3 and earlier has started to fail. The failures are caused by the npx install playwright --with-deps command. This step is not necessary for older branches because Playwright is not even used.

Change History (9)

This ticket was mentioned in PR #8522 on WordPress/wordpress-develop by @desrosj.


12 months ago
#1

In 6.4, the E2E tests switched to using Playwright. Earlier branches continue to utilize Puppeteer.

Recently, the E2E testing workflow in 6.3 and earlier has started to fail. The cause is coming from the npx install playwright --with-deps command. This step is not necessary for older branches because Playwright is not even used.

This adds an input to the reusable workflow to allow this step to be easily skipped for older branches.

Trac ticket: https://core.trac.wordpress.org/ticket/63117

#2 @desrosj
12 months ago

In 60005:

Build/Test Tools: Add input for skipping Playwright steps.

In older branches utilizing Puppeteer instead of Playwright, installing Playwright browsers is unnecessary and resulting in workflow failures.

This introduces a new install-playwright input that allows older branches to indicate that Playwright related steps should be skipped.

See #63117.

#4 @desrosj
12 months ago

In 60006:

Build/Test Tools: Don’t install Playwright browsers in 6.3 branch.

This makes use of the new input added in [60005] that allows older branches to skip Playwright related steps.

See #63117.

#5 @desrosj
12 months ago

In 60008:

Build/Test Tools: Don’t install Playwright browsers in 6.2 branch.

This makes use of the new input added in [60005] that allows older branches to skip Playwright related steps.

Merges [60006] to the 6.2 branch.
See #63117.

#6 @desrosj
12 months ago

In 60009:

Build/Test Tools: Don’t install Playwright browsers in 6.1 branch.

This makes use of the new input added in [60005] that allows older branches to skip Playwright related steps.

Merges [60006] to the 6.1 branch.
See #63117.

#7 @desrosj
12 months ago

In 60010:

Build/Test Tools: Don’t install Playwright browsers in 6.0 branch.

This makes use of the new input added in [60005] that allows older branches to skip Playwright related steps.

Merges [60006] to the 6.0 branch.
See #63117.

#8 @desrosj
12 months ago

In 60011:

Build/Test Tools: Don’t install Playwright browsers in 5.9 branch.

This makes use of the new input added in [60005] that allows older branches to skip Playwright related steps.

Merges [60006] to the 5.9 branch.
See #63117.

#9 @desrosj
12 months ago

  • Owner set to desrosj
  • Resolution set to fixed
  • Status changed from new to closed

In 60012:

Build/Test Tools: Don’t install Playwright browsers in 5.8 branch.

This makes use of the new input added in [60005] that allows older branches to skip Playwright related steps.

Merges [60006] to the 5.8 branch.
Fixes #63117.

Note: See TracTickets for help on using tickets.