Make WordPress Core

Opened 4 weeks ago

Last modified 3 weeks ago

#63126 accepted enhancement

Theme preview model and Media library model having issues with Shift/Ctrl + Shift next and previous arrows.

Reported by: praful2111's profile praful2111 Owned by: joedolson's profile joedolson
Milestone: 6.9 Priority: normal
Severity: normal Version: 6.7.2
Component: Themes Keywords: has-patch has-testing-info
Focuses: accessibility Cc:

Description

When we open the theme preview model and try to select text using the Shift/Ctrl+Shift with a left and right arrow then the theme modal switches the theme instead of the selecting text.

Screen recording - https://www.awesomescreenshot.com/video/37791980

Attachments (3)

63126.patch (903 bytes) - added by praful2111 4 weeks ago.
Patch added
63126.2.patch (903 bytes) - added by praful2111 4 weeks ago.
Patch added
63126-theme-and-edit-attachments.patch (1.5 KB) - added by hiteshtalpada 3 weeks ago.
Added theme and media library model patch

Download all attachments as: .zip

Change History (10)

@praful2111
4 weeks ago

Patch added

@praful2111
4 weeks ago

Patch added

#1 @praful2111
4 weeks ago

  • Keywords has-patch added; needs-patch removed

#3 @hiteshtalpada
4 weeks ago

  • Keywords has-testing-info added

Test Report

Description

This report validates whether the indicated patch works as expected.

Patch tested: https://core.trac.wordpress.org/attachment/ticket/63126/63126.patch

Environment

  • WordPress: 6.8-beta3-60042-src
  • PHP: 8.2.25
  • Server: nginx/1.27.2
  • Database: mysqli (Server: 8.4.2 / Client: mysqlnd 8.2.25)
  • Browser: Chrome 134.0.0.0
  • OS: Linux
  • Theme: Twenty Twenty-Five 1.1
  • MU Plugins: None activated
  • Plugins:
    • Test Reports 1.2.0

Actual Results

  1. ✅ Issue resolved with patch.

#4 @joemcgill
4 weeks ago

  • Milestone changed from Awaiting Review to 6.9

Hi @praful2111. Thanks for the report and for including a patch!

I can reproduce the issue and confirmed that this was existing behavior in 6.7. Given that we're so close to the release deadline for 6.8, I'm adding this to the 6.9 milestone for consideration.

This ticket was mentioned in Slack in #accessibility by joedolson. View the logs.


3 weeks ago

#6 @joedolson
3 weeks ago

  • Owner set to joedolson
  • Status changed from new to accepted

The same issue occurs in the media library modal. We can probably resolve both in this ticket; but if it proves to be a significantly different solution, we should open a separate ticket.

#7 @hiteshtalpada
3 weeks ago

  • Summary changed from Theme preview model having issues with Shift/Ctrl + Shift next and previous arrows. to Theme preview model and Media library model having issues with Shift/Ctrl + Shift next and previous arrows.

Hi @joedolson Thanks for pointing that out!

I've created a patch that should resolve the issue in the media library model.

@hiteshtalpada
3 weeks ago

Added theme and media library model patch

Note: See TracTickets for help on using tickets.