Make WordPress Core

Opened 18 months ago

Closed 18 months ago

Last modified 10 months ago

#63134 closed defect (bug) (wontfix)

Twenty Sixteen: Comments block having font size issue.

Reported by: nidhidhandhukiya Owned by: davidbaumwald
Priority: normal Milestone:
Component: Bundled Theme Version:
Severity: normal Keywords: has-test-info
Cc: Focuses: ui, css

Description

Steps to reproduce the issue :-

  1. Activate Twenty Sixteen theme.
  2. Choose Comments block.
  3. Apply font size.

You can able to see that if we applied font size change into the main comments block then it is not applied to the inner data in the front end.

I have attached video for better understanding.
Video URL :- https://www.awesomescreenshot.com/video/37847780?key=f32d9a5a1a27e2b4c8eb4e3eca1a5c32

Attachments (1)

63134.patch (553 bytes ) - added by nidhidhandhukiya 18 months ago.

Download all attachments as: .zip

Change History (6)

#1 @tusharaddweb
18 months ago

  • Focuses ui css added
  • Keywords has-testing-info added
  • Versiontrunk

Test Environment:

WordPress Version: 6.8.1 beta
Theme: Twenty Sixteen
PHP Version: 8.1


Test Scenario

Activate the Twenty Sixteen theme.
Add a Comments Block to a page or post.
Apply a font size change to the main Comments Block using the block editor.
Publish the page and view the front end.
Observe if the font size change is reflected in both the main block and the inner comments text.

Expected Result

The font size change applied to the Comments Block should reflect on the inner comments text in the front end.

Actual Result (Before Patch)

❌ The font size change was not applied to the inner comments text on the front end.
The issue was caused by missing CSS rules for inner elements of the Comments Block.

Actual Result (After Patch Applied)

✅ Issue Fixed: Font size change now applies correctly to both the main Comments Block and the inner comment text.

Attachments

https://prnt.sc/m6PlIvspPP-6
https://prnt.sc/ZkU9-hhhdmjU
https://prnt.sc/FS9ke0VHgf4m
https://prnt.sc/zlnbRJAMTamR
https://prnt.sc/_iMU_3f3RVuA

Test Conclusion

Status: ✅ Fixed After Patch
Impact: Medium (Affects block editor usability and frontend display)
Recommendation:

Ensure the patch is included in the next WordPress core release.
Verify the fix on other themes using the Comments Block.
Test additional typography settings (e.g., font weight, line height) for consistency.

#2 @sabernhardt
18 months ago

  • Milestone Awaiting Review
  • Resolutionwontfix
  • Status newclosed
  • Summary Twenty Sixteen - Comment block having font size issue.Twenty Sixteen: Comments block having font size issue.
  • Version trunk

Please do not test the Comments or Post Comments Form blocks in 'classic' PHP-based themes, where those two blocks are rarely appropriate. Twenty Ten to Twenty Twenty-One already have comments forms in their PHP templates, and then the block creates fields with duplicate IDs. Theoretically the site developer could go through the trouble of changing the template and adding the block to every post individually, but then a few CSS changes should be the easy part. See #55744, #61323 and #61327.

For future patches:

  • Avoid !important (#26350).
  • Themes such as Twenty Sixteen have a blocks.css stylesheet for block-related styles.
  • Use the same spacing as the rest of the file. In most themes, indent with tabs and have an empty line between CSS rulesets.

#3 @wordpressdotorg
16 months ago

  • Keywords has-test-info added; has-testing-info removed

#4 @davidbaumwald
10 months ago

  • Owner set to davidbaumwald
  • Resolution wontfixfixed

In 61216:

Post 6.9 branching version update.

Trunk is now 7.0-alpha.

Props jorbin, ella.
Fixes #63134.

#5 @sabernhardt
10 months ago

  • Resolution fixedwontfix

(The branching commit was for ticket:64235.)

Last edited 10 months ago by sabernhardt (previous) (diff)
Note: See TracTickets for help on using tickets.