#63176 closed defect (bug) (fixed)
Editor: Update the blocks on the sample page to the latest HTML
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Milestone: | 6.9 | Priority: | normal |
| Severity: | normal | Version: | 6.1 |
| Component: | Editor | Keywords: | has-patch has-test-info commit |
| Focuses: | Cc: |
Description
The Sample Page includes updated Quote blocks, so if you open the editor, You'll see a log in your browser console indication the block has been migrated:
Block successfully updated for `core/quote` ({name: 'core/quote', icon: {…}, keywords: Array(2), attributes: {…}, providesContext: {…}, …}).
New content generated by `save` function:
<blockquote class="wp-block-quote"></blockquote>
Content retrieved from post body:
<blockquote class="wp-block-quote"><p>Hi there! I'm a bike messenger by day, aspiring actor by night, and this is my website. I live in Los Angeles, have a great dog named Jack, and I like piña coladas. (And gettin' caught in the rain.)</p></blockquote>
Block successfully updated for `core/quote` ({name: 'core/quote', icon: {…}, keywords: Array(2), attributes: {…}, providesContext: {…}, …}).
New content generated by `save` function:
<blockquote class="wp-block-quote"></blockquote>
Content retrieved from post body:
<blockquote class="wp-block-quote"><p>The XYZ Doohickey Company was founded in 1971, and has been providing quality doohickeys to the public ever since. Located in Gotham City, XYZ employs over 2,000 people and does all kinds of awesome things for the Gotham community.</p></blockquote>
We may want to update the block's HTML to avoid this log.
This HTML is in core: https://github.com/t-hamano/wordpress-develop/blob/ed2f2ecd3fa043eca3a064a95fcb4830b5c0765c/src/wp-admin/includes/upgrade.php#L313-L339
Change History (10)
This ticket was mentioned in PR #8592 on WordPress/wordpress-develop by @wildworks.
8 months ago
#1
- Keywords has-patch added
#2
@
8 months ago
How to test the PR
- Apply the PR to your local env
- Build:
npm run build:dev - Initialize your local env:
npm run env:reset,npm run env:start,npm run env:install - Open your browser console panel
- Access http://localhost:8889/wp-admin/post.php?post=2&action=edit
- Confirm that no message is logged
@ankitkumarshah commented on PR #8592:
8 months ago
#3
#4
@
8 months ago
- Keywords has-testing-info added
Thanks for the PR, @wildworks.
I have tested it according to the instructions provided, and the issue is resolved ✅
#5
@
8 months ago
Hello and thanks for the ticket/patch.
I confirm the patch fixes the issue. When was this markup change introduced in the Quote block? I doubt it was introduced in 6.8 but I'm asking to check whether it has to be fixed in 6.8 or 6.9.
#6
@
8 months ago
I think the markup change was introduced by https://github.com/WordPress/gutenberg/pull/25892.
It was Gutenberg 13.8, or WordPress 6.1, so there is no need to rush.
#7
@
8 months ago
- Keywords commit added
- Milestone changed from Awaiting Review to 6.9
- Owner set to audrasjb
- Status changed from new to accepted
- Version set to 6.1
Alright, thank you!
Let's address this in 6.9 then :)
Trac ticket: https://core.trac.wordpress.org/ticket/63176