Make WordPress Core

#63196 closed enhancement (fixed)

Typo correction

Reported by: mujuonly Owned by: audrasjb
Priority: normal Milestone: 6.9
Component: Administration Version: 4.9
Severity: minor Keywords: has-patch commit
Cc: Focuses: css, docs

Description

Typo correction in CSS comment.

Change History (9)

This ticket was mentioned in PR #8617 on WordPress/wordpress-develop by @mujuonly.


17 months ago
#1

  • Keywords has-patch added

Typo correction

Trac ticket: https://core.trac.wordpress.org/ticket/63196

#2 @sabernhardt
17 months ago

  • Component GeneralAdministration
  • Focuses docs added
  • Milestone Awaiting Review6.9
  • Version4.9

[41329] added the comment 'Needs higher specificiity.'

Because this ticket is labeled an enhancement, explaining which selector the higher specificity overrides could be more helpful. Or else it might say how many classes it needs.

39662.diff included the comment when it changed .wp-color-result to .wp-picker-container .wp-color-result, and 39662.2.diff added a third class (.wp-picker-container .wp-color-result.button).

#3 @sabernhardt
17 months ago

It seems to need at least two classes to override .wp-core-ui .button in the Customizer.

#4 @audrasjb
17 months ago

  • Keywords changes-requested added
  • Owner set to audrasjb
  • Status newaccepted

Yes, let's take advantage of this ticket to clarify this docblock.

#5 @dhruvang21
13 months ago

Comment Suggestion:

/* 
 * Requires at least two class-level selectors (e.g., 
 * '.wp-picker-container .wp-color-result') to override the 
 * '.wp-core-ui .button' style in the Customizer. 
 * Add a third class (e.g., '.button') for increased specificity.
 */

or a bit short:

/* Use .wp-picker-container .wp-color-result to override .wp-core-ui .button */

#6 @sabernhardt
13 months ago

Or simply:

/* Needs higher specificity to override `.wp-core-ui .button`. */

#7 @shailu25
13 months ago

  • Keywords changes-requested removed

#8 @audrasjb
12 months ago

  • Keywords commit added

#9 @audrasjb
12 months ago

  • Resolutionfixed
  • Status acceptedclosed

In 60526:

Docs: Typo correction and comment improvement in color-picker.css.

Props mujuonly, sabernhardt, dhruvang21.
Fixes #63196.
See #63166.

Note: See TracTickets for help on using tickets.