FTPext Stub

[SirLouen]

Healthiness stub for FTPext

A simple patch to fix a disturbing type error for stubs

[audrasjb]

"to fix a disturbing type error" could you please add some details about the type error reported?

[SirLouen]

@audrasjb as It's just a stubs issue
This file was updated some months ago, according to the new PHP 8.1 standard, to use FTP/Connection, instead of resource.
But someone forgot to update the docs $link type when they introduce the update.
So when you use any type of code parser with anything over PHP 8.1, you will see the code plagued with typing errors like: $this->link is not a resource but a FTP/Connection
I've kept resource for anything below PHP 8.1 compatibility (and because the current $link instantiation is still using the resource mode).

You can check the errors with any parser that use the ​wordpress stubs, intellisense, phpstan...

[kalpeshh]

​https://www.php.net/manual/en/function.ftp-ssl-connect.php

Returns an FTP\Connection instance on success, or false on failure.

ftp_ssl_connect returns false on ftp connection failure so $link can also be false.

To handle that case we can think of adding

/** @var FTP\Connection|resource|false */

[welcher]

Reviewed in the 6.9 bug scrub today and this looks ready for commit.

[westonruter]

In 61116:

Filesystem API: Update WP_Filesystem_FTPext::$link phpdoc type.

This accounts for when ftp_ssl_connect()/ftp_connect() returns false as well as for when FTP\Connection is returned instead of resource as of PHP 8.1.

Props SirLouen, kalpeshh, audrasjb.
Fixes #63201.