Make WordPress Core

Opened 7 weeks ago

Closed 6 weeks ago

#63215 closed defect (bug) (fixed)

Docs: Update inline docs for General template functions

Reported by: dilipbheda's profile dilipbheda Owned by: audrasjb's profile audrasjb
Milestone: 6.8 Priority: normal
Severity: normal Version:
Component: General Keywords: has-patch commit dev-feedback
Focuses: docs Cc:

Description

I reviewed the following function and found that the inline docs are missing the null param type and default value description. e.g: Default false.

  • get_header()
  • get_footer()
  • get_sidebar()
  • get_template_part()
  • get_archives_link()

Change History (7)

This ticket was mentioned in PR #8636 on WordPress/wordpress-develop by @dilipbheda.


7 weeks ago
#1

#2 @audrasjb
7 weeks ago

  • Keywords commit added
  • Milestone changed from Awaiting Review to 6.9
  • Owner set to audrasjb
  • Status changed from new to accepted

@audrasjb commented on PR #8636:


7 weeks ago
#3

This looks good to me. Please note that I'll fix a small indentation issue on line 200 when committing this change.

#4 @audrasjb
7 weeks ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 60120:

Docs: Update inline docs for various general template functions.

Props dilipbheda, mukesh27.
Fixes #63215.
See #63166.

#5 @SergeyBiryukov
7 weeks ago

In 60121:

Docs: Correct the type of the $name parameter in get_template_part action.

The value cannot be null at this point, as it is converted to a string a few lines above.

Follow-up to [45059], [55870], [60120].

See #63215, #63166.

#6 @peterwilsoncc
7 weeks ago

  • Keywords dev-feedback added
  • Milestone changed from 6.9 to 6.8
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening and moving to the 6.8 milestone for r60120, r60121 to be considered for merging to the 6.8 branch.

#7 @jorbin
6 weeks ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 60139:

Docs: Update inline docs for various general template functions.

Reviewed By peterwilsoncc, jorbin.
Merges [60120] and [60121] to the 6.8 branch.

Props dilipbheda, mukesh27, SergeyBiryukov, audrasjb.
Fixes #63215.
See #63166.

Note: See TracTickets for help on using tickets.