WordPress.org
Get WordPress

Make WordPress Core

Opened 8 months ago

Last modified 2 weeks ago

#63222 reviewing defect (bug)

register_block_type is not working with symbolic links still

Reported by: kkmuffme's profile kkmuffme Owned by: audrasjb's profile audrasjb
Milestone: Future Release Priority: normal
Severity: normal Version:
Component: Editor Keywords: has-patch needs-test-info
Focuses: Cc:

Description

https://core.trac.wordpress.org/changeset/57675 introduced some changes to fix it for some symlinks, but broke it for other symlinks, and it was still broken if wp-includes is symlinked.
This is bc it's comparing symlink resolved realpaths with normalized (but not symlink resolved) paths - which it seems was an issue we were aware though already: https://core.trac.wordpress.org/ticket/59175#comment:9

Change History (7)

This ticket was mentioned in ​PR #8643 on ​WordPress/wordpress-develop by ​@kkmuffme.
8 months ago #1

  • Keywords has-patch added

Trac ticket: https://core.trac.wordpress.org/ticket/63222

#2 @audrasjb
8 months ago

  • Milestone changed from Awaiting Review to 6.9
  • Status changed from assigned to reviewing

Thanks for the PR. I added a commit in it to fix a small coding standards issue.

#3 @mindctrl
4 months ago

  • Keywords needs-testing added

#4 @sourabhjain
4 months ago

@mindctrl or anyone else — could please provide the testing steps? Or help clarify which block is being referred to here, so we can test this on the frontend without digging into the code?

#5 @SirLouen
4 months ago

  • Keywords needs-test-info added; needs-testing removed

This ticket was mentioned in ​Slack in #core by welcher. ​View the logs.
2 weeks ago

#7 @welcher
2 weeks ago

  • Milestone changed from 6.9 to Future Release

This was reviewed today in the 6.9 bug scrub. There has been no activity for 3 months and we're 1 week away from RC1 so I am going to move it to future release.

Note: See TracTickets for help on using tickets.