Opened 11 months ago
Closed 11 months ago
#63250 closed defect (bug) (reported-upstream)
Docs: Improve document and parameters in render_block_core_* function
| Reported by: |
|
Owned by: | |
|---|---|---|---|
| Milestone: | Priority: | normal | |
| Severity: | normal | Version: | |
| Component: | Editor | Keywords: | has-patch changes-requested |
| Focuses: | docs | Cc: |
Description
While reviewing the core-registered block callback functions in wp-includes/blocks/, I noticed that some inline documentation references undeclared variables. These should be corrected for clarity and accuracy.
Additionally, in the render_block_core_latest_comments function, I updated the $attributes = array() default to just $attributes since the callback already passes the value into the function. I compared this with other blocks callbacks and removed the unnecessary default assignment to maintain consistency.
Change History (5)
This ticket was mentioned in PR #8663 on WordPress/wordpress-develop by @dilipbheda.
11 months ago
#1
#3
@
11 months ago
@audrasjb Thank you for your response. I've submitted [pull request]https://github.com/WordPress/gutenberg/pull/69856 to the GitHub repository.
@wildworks commented on PR #8663:
11 months ago
#4
@dilipbheda These files are automatically synced from Gutenberg to core, so they cannot be modified in core.
Let's close this PR and move forward with the Gutenberg PR: https://github.com/WordPress/gutenberg/pull/69856
#5
@
11 months ago
- Milestone Awaiting Review deleted
- Resolution set to reported-upstream
- Status changed from new to closed
This issue has been fixed on Gutenberg: https://github.com/WordPress/gutenberg/pull/69856
Hello, the files located in wp-includes/blocks can not be updated directly on core, they must be updated upstream in Gutenberg GitHub repository.