Make WordPress Core

Opened 16 months ago

Last modified 16 months ago

#63259 new defect (bug)

Replace zxcvbn with zxcvbn-ts

Reported by: fseydel Owned by:
Priority: normal Milestone: Awaiting Review
Component: Security Version:
Severity: normal Keywords:
Cc: Focuses: javascript

Description

The password-strength-meter in wp-admin uses the 12 year old package zxcvbn 4.4.1.

This package has a known vulnerability: https://security.snyk.io/package/npm/zxcvbn/4.4.1

Using this package failed a pentest on a customers WordPress website.

An idea would be to switch to zxcvbn-ts (https://github.com/zxcvbn-ts/zxcvbn) which is up-to-date and has no known vulnerability.

Migration should easily be possible: https://zxcvbn-ts.github.io/zxcvbn/guide/migration/#zxcvbn-4-4-2-to-zxcvbn-ts-0-1-0

Change History (4)

#1 @fseydel
16 months ago

Feedback from the Bavarian "Landesamt für Sicherheit in der Informationstechnik":
"The vulnerability only affects the availability of the website in the client's browser and does not pose a threat to the server side, provided the affected library is only used on the client side. However, this still constitutes a violation of the administrative regulation BayITSiR-14, section 3.4 d), since security patches (including those from third-party products) must be installed immediately."

#2 follow-up: @audrasjb
16 months ago

  • Component External LibrariesSecurity
  • Severity majornormal
  • Type enhancementdefect (bug)

Hello, thank you for reporting this, but didn't you notice the information about Security issues when you opened this ticket? While this is not an important one, please note that Security issues should be opened privately on Hackerone first.

#3 @sabernhardt
16 months ago

  • Summary Usage of zxcvbn 4.4.1 with known vulnerabilityReplace zxcvbn with zxcvbn-ts

Related: #43749

#4 in reply to: ↑ 2 @fseydel
16 months ago

Replying to audrasjb:

Hello, thank you for reporting this, but didn't you notice the information about Security issues when you opened this ticket? While this is not an important one, please note that Security issues should be opened privately on Hackerone first.

Sorry, my fault. Won't happen again.

Note: See TracTickets for help on using tickets.