Coding Standards: Check for an empty $old_email first in wp_site_admin_email_change_notification()

[dilipbheda]

In the wp_site_admin_email_change_notification() function, the current logic checks the $old_email variable for a specific default value before checking if it's empty:

<?php
if ( 'you@example.com' === $old_email || empty( $old_email ) ) {
        $send = false;
}

This should be reordered to first check if $old_email is empty:

<?php
if ( empty( $old_email ) || 'you@example.com' === $old_email ) {
        $send = false;
}

This change follows a common best practice: always check for empty or null values first to avoid unnecessary comparisons or potential errors. It also aligns better with readability and expected evaluation flow.

[Presskopp]

How comes the code is different on ​https://developer.wordpress.org/reference/functions/wp_site_admin_email_change_notification/ ?

if ( 'you@example.com' === $old_email ) {
    $send = false;
}

[dilipbheda]

@Presskopp I found it in the GitHub repo here: - ​https://github.com/WordPress/wordpress-develop/blob/a04a13a1d0039b6054a4276def28eedecc9cb9ad/src/wp-includes/functions.php#L8122

[dilipbheda]

I think it changed 7 days ago with this [GitHub issue]​https://github.com/dilipbheda/wordpress-develop/issues/62211, but I can't access it to review the changes.

Ref: ​https://tinyurl.com/2yk94pdn

[Presskopp]

​https://github.com/WordPress/WordPress/commit/d06ea932ded9335ad576539c0ece80e45cf46ddb

​https://github.com/WordPress/wordpress-develop/pull/7560

#62211

[dilipbheda]

@Presskopp Thank you for the sharing; I've updated the multisite function as well in my opened PR.

[dilipbheda]

Related to https://core.trac.wordpress.org/ticket/62211

[SergeyBiryukov]

In 60153:

Coding Standards: Check for an empty address first on admin email change notification.

This follows a common best practice of checking for an empty value before doing a specific comparison.

Follow-up to [60122], [60129].

Props dilipbheda, Presskopp.
Fixes #63267.