WordPress.org
Get WordPress

Make WordPress Core

Opened 7 months ago

Closed 5 months ago

#63278 closed defect (bug) (fixed)

Remove use of deprecated `issuesAndPullRequests()` method

Reported by: desrosj's profile desrosj Owned by: desrosj's profile desrosj
Milestone: 6.9 Priority: normal
Severity: normal Version:
Component: Build/Test Tools Keywords: good-first-bug has-patch
Focuses: Cc:

Description

The github.rest.search.issuesAndPullRequests method is deprecated and scheduled for removal in ​September 2025.

Use of this should be removed from GitHub Action workflows.

This is currently only used in the workflow that searches for pull requests that should be closed as a result of the commit.

Attachments (1)

63278.patch​ (859 bytes) - added by abcd95 7 months ago.

Download all attachments as: .zip

Change History (7)

@abcd95
7 months ago

#1 @abcd95
7 months ago

I think this might work since the existing search query already includes is:pr and this aligns with that. However, I am not sure how to test this.

This ticket was mentioned in ​PR #8740 on ​WordPress/wordpress-develop by ​@abcd95.
7 months ago #2

  • Keywords has-patch added

#3 @desrosj
5 months ago

  • Owner set to desrosj
  • Resolution set to fixed
  • Status changed from new to closed

In 60314:

Build/Test Tools: Use issues instead of issuesAndPullRequests.

The github.rest.search.issuesAndPullRequests() method is deprecated and slated to be removed in September 2025.

The preferred way to search for pull requests is now to use github.rest.search.issues in combination with the is:pr or type:pr qualifiers.

Props abcd95.
Fixes #63278.

#4 @desrosj
5 months ago

  • Milestone changed from Awaiting Review to 6.9

#5 @desrosj
5 months ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

It seems this is not quite right. Also, GraphQL can be much more efficient, so let's just switch to using that instead.

#6 @desrosj
5 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 60315:

Build/Test Tools: Switch to the GraphQL API for searching pull requests.

The GraphQL API is more flexible and efficient than the REST API.

This switches the pull request search code to use the former.

Fixes #63278.

Note: See TracTickets for help on using tickets.