WordPress.org
Get WordPress

Make WordPress Core

Opened 18 months ago

Closed 17 months ago

Last modified 10 months ago

#63297 closed defect (bug) (invalid)

Add escaping on class variable in themes.php file

Reported by: harishtewari Owned by:
Priority: normal Milestone:
Component: Themes Version:
Severity: normal Keywords: has-patch close
Cc: Focuses: coding-standards

Description

Escaping HTML attributes in themes.php file on line 435

Change History (6)

#3 @sabernhardt
18 months ago

  • Keywords close added

Thanks for the ticket and patch!

The $active_class variable is either ' active' or an empty string, and those would not require escaping.

I think this should be closed for the same reason as #58251, #59626 and #61378.

#4 @SergeyBiryukov
18 months ago

  • Component General → Themes

#5 @karmatosed
17 months ago

  • Milestone Awaiting Review
  • Resolution → invalid
  • Status new → closed

I am going to agree with the recommendation to follow through on this and close. Thank you everyone.

​@SergeyBiryukov commented on ​PR #8702:
10 months ago #6

Thanks for the PR! Closing for now, as the associated Trac ticket has been closed.

Note: See TracTickets for help on using tickets.