WordPress.org
Get WordPress

Make WordPress Core

Opened 13 months ago

Closed 12 months ago

Last modified 5 months ago

#63297 closed defect (bug) (invalid)

Add escaping on class variable in themes.php file

Reported by: harishtewari's profile harishtewari Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Themes Keywords: has-patch close
Focuses: coding-standards Cc:

Description

Escaping HTML attributes in themes.php file on line 435

Change History (6)

#3 @sabernhardt
13 months ago

  • Keywords close added

Thanks for the ticket and patch!

The $active_class variable is either ' active' or an empty string, and those would not require escaping.

I think this should be closed for the same reason as #58251, #59626 and #61378.

#4 @SergeyBiryukov
13 months ago

  • Component changed from General to Themes

#5 @karmatosed
12 months ago

  • Milestone Awaiting Review deleted
  • Resolution set to invalid
  • Status changed from new to closed

I am going to agree with the recommendation to follow through on this and close. Thank you everyone.

​@SergeyBiryukov commented on ​PR #8702:
5 months ago #6

Thanks for the PR! Closing for now, as the associated Trac ticket has been closed.

Note: See TracTickets for help on using tickets.