WordPress.org
Get WordPress

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #63302, comment 25


Ignore:
Timestamp:
04/19/2025 03:23:53 PM (12 months ago)
Author:
SirLouen
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #63302, comment 25

    initial v1  
    55Yes I was exactly [https://core.trac.wordpress.org/ticket/63302?replyto=24#comment:18 thinking this here], but with all the futureproofing thing, I came down to this alternative
    66
    7 Although I think that its not wrong to set some sort of const or even a variable array to set descriptively this particular scenario.
    8 
    97The problem is that the check is picking supported formats from GD, and obv, SVG is not included, resulting in a failure. So, anything like "NON_RESIZABLE_FORMATS" (maybe not global, but at least local or at minimum a descriptive array variable, will help debug and come through in the future (agreeing with @pbiron) _just in case_ there is an unlikely new format in the future (instead of just hard-coding the format as I suggested previously)
    108