tinymce cache key should be updated

[oferlaor]

when I paste a youtube link into wordpress classic editor, I get this error:

tinymce.min.js?ver=49110-20201110:2 Uncaught IndexSizeError: Failed to execute ‘setStart’ on ‘Range’: There is no child at offset 12.
at Kh (tinymce.min.js?ver=49110-20201110:2:218016)
at tN. (tinymce.min.js?ver=49110-20201110:2:410)
at c.fire (tinymce.min.js?ver=49110-20201110:2:197006)
at tN.fire (tinymce.min.js?ver=49110-20201110:2:197532)
at ev.nodeChanged (tinymce.min.js?ver=49110-20201110:2:220592)
at tN.nodeChanged (tinymce.min.js?ver=49110-20201110:2:345084)
at tN. (tinymce.min.js?ver=49110-20201110:2:220079)
at c.fire (tinymce.min.js?ver=49110-20201110:2:197006)
at tN.fire (tinymce.min.js?ver=49110-20201110:2:197532)
at Pp (tinymce.min.js?ver=49110-20201110:2:199169)

So, I tried to compare what I had with 6.7.2, turns out the issue is that there are small changes to TinyMCE (not sure since when) but the cache key (wp-includes/version.php) has not been updated for a while.

$tinymce_version = '49110-20201110';

For sites that have no cloudflare/similar cache, it might not make a difference, but those that might get an incorrect tinymce version and some errors...

[sabernhardt]

Hi and welcome!

[60007] edited TinyMCE-related files, but I did not find an update to tinymce.min.js (or tinymce.js).
https://core.trac.wordpress.org/browser/trunk/src/js/_enqueues/vendor/tinymce

[siliconforks]

Replying to sabernhardt:

[60007] edited TinyMCE-related files, but I did not find an update to tinymce.min.js (or tinymce.js).

It seems like that version (49110-20201110) is being used for a lot of other URLs besides just tinymce.min.js though.

For example, when I try using the classic editor with SCRIPT_DEBUG set to true, it requests the URL wp-includes/js/tinymce/plugins/wordpress/plugin.js?wp-mce-49110-20201110 (but that is one of the files modified in [60007]).

Trac ticket: https://core.trac.wordpress.org/ticket/63308

[audrasjb]

Hello and thanks for the ticket,
@oferlaor are you able to confirm the issue is fixed when you try to manually update the cache key on your side?

[oferlaor]

Yep. That’s how I fixed it

[audrasjb]

In 60413:

TinyMCE: Update TinyMCE cache version to prevent script errors.

Changeset [60007] updated some TinyMCE-related files but did not update the $tinymce_version cache key located in wp-includes/version.php. This changeset updates the cache key with the date of the last changes.

Follow-up to [60007].

Props oferlaor, sabernhardt, siliconforks, audrasjb.
Fixes #63308.

[audrasjb]

Reopening for 6.8 branch backport.

[audrasjb]

In 60436:

TinyMCE: Update TinyMCE cache version to prevent script errors.

Changeset [60007] updated some TinyMCE-related files but did not update the $tinymce_version cache key located in wp-includes/version.php. This changeset updates the cache key with the date of the last changes.

Follow-up to [60007].

Merges [60413] to the 6.8 branch.
Props oferlaor, sabernhardt, siliconforks, audrasjb.
Fixes #63308.