Make WordPress Core

Changes between Version 2 and Version 3 of Ticket #63316, comment 26


Ignore:
Timestamp:
07/24/2025 03:11:41 PM (13 months ago)
Author:
SirLouen

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #63316, comment 26

    v2 v3  
    11Given that there are so many values now, I have implemented a little mod in my PR that is a little simpler than so many conditionals.
    22
    3 Maybe we should be adding tests, but `assertCanonical` doesn't admit headers for host and scheme, only the URL perhaps another function is required, or improving it to accept Headers.
     3Maybe we should be adding tests, but `assertCanonical` forces `example.com` so its impossible to trigger empty host and scheme.
    44
    55I've only added one Unit Test to check for the absence of path and query as in #63733 but handling Host and Scheme is a little bit more tricky (at least with that function that is only testing for canonical paths)