Make WordPress Core

Opened 3 weeks ago

Last modified 7 days ago

#63324 reopened task (blessed)

Update Twemoji to v16.0.1

Reported by: jeffpaul's profile JeffPaul Owned by: peterwilsoncc's profile peterwilsoncc
Milestone: 6.8.2 Priority: normal
Severity: normal Version:
Component: Emoji Keywords: has-patch has-unit-tests dev-feedback
Focuses: Cc:

Description

Twemoji 16.0.1 has been released, adding support for Emoji 16.0.

This release introduces 8 new Emoji that WordPressers, especially those from Sark, will want to use in their blog posts.

Change History (11)

This ticket was mentioned in PR #8720 on WordPress/wordpress-develop by @abcd95.


3 weeks ago
#1

  • Keywords has-patch added; needs-patch removed

#2 @abcd95
3 weeks ago

  • Keywords good-first-bug removed

I think this is going to be a little more complex according to this comment -

https://core.trac.wordpress.org/ticket/63064#comment:13

#3 @SergeyBiryukov
9 days ago

  • Milestone changed from Awaiting Review to 6.9

#4 @peterwilsoncc
9 days ago

I've logged #Meta7970 to cover uploading the images to the CDN.

Please do not continue work on this ticket until the meta ticket is completed.

Doing so will warm the CDN's endpoints for the URLs while they throw a 404 error, and the region will server the 404s forever more.

#5 @dd32
9 days ago

Per https://meta.trac.wordpress.org/ticket/7970#comment:1 these assets have now been deployed.

https://s.w.org/images/core/emoji/16.0.1/svg/1fadf.svg

This ticket was mentioned in PR #8774 on WordPress/wordpress-develop by @peterwilsoncc.


9 days ago
#6

  • Keywords has-unit-tests added

Updates to Emoji 16:

  • Introduces a new test to account for single data point emoji tests, emojiRendersEmptyCenterPoint
  • Adds a test for an Emoji 16 emoji, Shovel 🪏
  • Modesty aside, uses a pretty good pun in the comments
  • Updates the CDN URL to point to the 16.0.1 images.
  • Updates the grunt script to pull emoji images from the 16.0.1 version of Twemoji for generating the regex
  • Updates Twemoji (regex only change)
  • I'm leaving the bot to update the formatting.php regex.

Trac ticket: https://core.trac.wordpress.org/ticket/63324

#7 @peterwilsoncc
9 days ago

I've created a pull request to address this:

  • Introduces a new test to account for single data point emoji tests, emojiRendersEmptyCenterPoint
  • Updates the flag test from UN to Sark (CQ) 🇨🇶
  • Adds a test for an Emoji 16 emoji, Shovel 🪏
  • Modesty aside, uses a pretty good pun in the comments
  • Updates the CDN URL to point to the 16.0.1 images.
  • Updates the grunt script to pull emoji images from the 16.0.1 version of Twemoji for generating the regex
  • Updates Twemoji (regex only change)
  • The built files bot has updated the regex in formatting.php
Last edited 9 days ago by peterwilsoncc (previous) (diff)

@pento commented on PR #8774:


8 days ago
#8

I based the test for an empty center point on the tests in the version in the 4.2 branch, do you recall if that caused any problems?

This would potentially cause the test to incorrectly fail if the site or UA is using Noto Emoji Font, as it looks like the centre pixel for the shovel would be white. This is an extreme edge case that I usually wouldn't be concerned about, particularly as it hasn't caused any reported issues with the historical smiley used.

If you feel like addressing it, it could probably be mitigated by testing with the splatter emoji, instead.

@westonruter commented on PR #8774:


8 days ago
#9

Would you be able to validate that I am passing the new function around correctly for the support tests to continue working in workers?

@peterwilsoncc This looks good to me!

#10 @peterwilsoncc
7 days ago

  • Owner set to peterwilsoncc
  • Resolution set to fixed
  • Status changed from new to closed

In 60227:

Emoji: Update Twemoji to version 16.0.1.

Introduces support for Emoji 16:

  • replaces emoji support test with splatter 🫟,
  • replaces two letter coded flag support test with Sark 🇨🇶,
  • introduces the function emojiRendersEmptyCenterPoint() to the emoji loader to enable testing of emoji with a single data point.

Not to harp 🪉 on about it, but Emoji 16 is perfect for tiring yourself out 🫩 digging 🪏 up root vegetables 🫜 while visiting Sark 🇨🇶.

Props westonruter, kraftbj, pento, JeffPaul, abcd95, SergeyBiryukov, dd32, peterwilsoncc.
Fixes #63324.

#11 @peterwilsoncc
7 days ago

  • Keywords dev-feedback added
  • Milestone changed from 6.9 to 6.8.2
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for backport consideration to the 6.8 branch pending another committer's sign off.

Note: See TracTickets for help on using tickets.