siteurl and home fields not disabled in wp-admin/options.php when defined in wp-config.php

[dilipbheda]

When visiting the wp-admin/options.php page, the siteurl and home fields remain editable, even if the WP_SITEURL and WP_HOME constants are defined in wp-config.php.

Expected Behavior:
These fields should be disabled (read-only) just like they are on the General Settings page (wp-admin/options-general.php) when the constants are defined.

References:

• Current behavior on options.php: ​https://tinyurl.com/2b5aw5jd
• Expected behavior on General Settings page: ​https://tinyurl.com/26yfco7u

If a setting is defined in wp-config.php, disable the respective field.

Trac ticket: 63341

[Presskopp]

Good point! Patch made.

I'm closing this PR as another contributor has submitted a new one with more optimized code.

New PR ​https://github.com/WordPress/wordpress-develop/pull/8733

[SergeyBiryukov]

In 60237:

Options, Meta APIs: Disable siteurl and home fields on All Settings screen when defined as constants.

This aims to bring consistency with the General Settings screen, where these fields are disabled (read-only) if the WP_SITEURL and WP_HOME constants are defined in wp-config.php.

Follow-up to [208], [5093], [5394].

Props dilipbheda, Presskopp, SergeyBiryukov.
Fixes #63341.

[SergeyBiryukov]

In 60238:

Coding Standards: Move $class variable in wp-admin/options.php closer to where it's used.

Follow-up to [60237].

See #63341.

Thanks for the PR! Merged in r60237.