WordPress.org
Get WordPress

Make WordPress Core

Opened 10 months ago

Closed 10 months ago

Last modified 10 months ago

#63345 closed defect (bug) (fixed)

Twenty Twenty-Five: Remove echo from esc_html_e() in banner-cover-big-heading.php

Reported by: dilipbheda's profile dilipbheda Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 6.9 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch
Focuses: coding-standards Cc:

Description

In the patterns/banner-cover-big-heading.php file, I noticed that esc_html_e() is being used with echo, which is redundant since esc_html_e() already echoes the output.

Change History (4)

This ticket was mentioned in ​PR #8738 on ​WordPress/wordpress-develop by ​@dilipbheda.
10 months ago #1

#2 @sabernhardt
10 months ago

  • Milestone changed from Awaiting Review to 6.9
  • Summary changed from [Twenty Twenty-Five]: Remove echo from esc_html_e() in banner-cover-big-heading.php to Twenty Twenty-Five: Remove echo from esc_html_e() in banner-cover-big-heading.php

#3 @SergeyBiryukov
10 months ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 60192:

Twenty Twenty-Five: Remove redundant echo from esc_html_e().

Follow-up to [59233].

Props dilipbheda, sabernhardt.
Fixes #63345.

#4 @sabernhardt
10 months ago

Thanks for committing this!

For the record, I ran searches on echo esc_html_e( and echo esc_attr_e( but did not find any other instances in Core.

Note: See TracTickets for help on using tickets.