WordPress.org
Get WordPress

Make WordPress Core

Opened 2 weeks ago

Closed 10 days ago

#63363 closed defect (bug) (fixed)

Use is_wp_error() instead of instanceof WP_Error in class-wp-customize-custom-css-setting.php

Reported by: dilipbheda's profile dilipbheda Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 6.9 Priority: normal
Severity: normal Version: 4.7
Component: Customize Keywords: has-patch commit
Focuses: coding-standards Cc:

Description

While reviewing the update function in class-wp-customize-custom-css-setting.php, I noticed that it uses a direct instanceof WP_Error check instead of the is_wp_error() function.

For consistency with WordPress coding standards, direct instanceof WP_Error checks should be replaced with is_wp_error().

Change History (3)

This ticket was mentioned in ​PR #8748 on ​WordPress/wordpress-develop by ​@dilipbheda.
2 weeks ago #1

#2 @mukesh27
2 weeks ago

  • Keywords commit added
  • Milestone changed from Awaiting Review to 6.9
  • Version set to 4.7

Introduce in https://core.trac.wordpress.org/changeset/39350

#3 @SergeyBiryukov
10 days ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 60215:

Coding Standards: Use is_wp_error() in WP_Customize_Custom_CSS_Setting.

This brings more consistency with similar checks elsewhere in core.

Follow-up to [39350].

Props dilipbheda, mukesh27.
Fixes #63363.

Note: See TracTickets for help on using tickets.