Opened 2 months ago
Closed 2 months ago
#63390 closed defect (bug) (fixed)
Add version number tests for package-lock and composer files.
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 6.8.2 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Build/Test Tools | Keywords: | has-patch has-unit-tests dev-reviewed |
Focuses: | tests | Cc: |
Description
WordPress currently tests the version numbers are the same for version.php
, license.txt
and package.json
.
The same tests ought to be included for composer.json
(1 instance) and package-lock.json
(2 instances).
As WordPress is currently in a reduced release cadence for major releases, I intend to add these tests to both trunk and the 6.8 branch.
Pull request incoming.
Change History (6)
This ticket was mentioned in PR #8768 on WordPress/wordpress-develop by @peterwilsoncc.
2 months ago
#1
- Keywords has-patch has-unit-tests added
#2
@
2 months ago
- Owner set to peterwilsoncc
- Resolution set to fixed
- Status changed from new to closed
In 60219:
#3
@
2 months ago
- Keywords dev-feedback added
- Resolution fixed deleted
- Status changed from closed to reopened
Reopening to merge to the 6.8 branch.
Even thought the changes are to the tests files, I'll get another committer to sign off on the changes if someone could be so kind as to do so.
Note: See
TracTickets for help on using
tickets.
Adds version number tests for composer.json and package-lock.json.
These tests are the equivalent to the existing package.json test.
Trac ticket: https://core.trac.wordpress.org/ticket/63390
Initial push breaks the version numbers to demonstrate failing tests.