WordPress.org
Get WordPress

Make WordPress Core

Opened 11 months ago

Closed 11 months ago

Last modified 11 months ago

#63422 closed defect (bug) (fixed)

Fix missing closing backticks in `button.js` code comment

Reported by: ankitkumarshah's profile ankitkumarshah Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 6.9 Priority: normal
Severity: normal Version:
Component: Media Keywords: has-patch
Focuses: docs Cc:

Description

There's a missing closing backtick in the button.js file in an inline comment

// value to the `model` and remove it from the `options object.

​https://github.com/WordPress/wordpress-develop/blob/3f9317c2aa2ba650c0d930acaca1bb840c95a6da/src/js/media/views/button.js#L36

Change History (5)

This ticket was mentioned in ​PR #8788 on ​WordPress/wordpress-develop by ​@ankitkumarshah.
11 months ago #1

  • Keywords has-patch added

#63422

#2 @getsyash
11 months ago

@ankitkumarshah Thank you for the ticket and PR. PR looks good to me.

#3 @SergeyBiryukov
11 months ago

  • Component changed from General to Media
  • Milestone changed from Awaiting Review to 6.9

#4 @SergeyBiryukov
11 months ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 60229:

Docs: Add missing closing backtick in a comment in js/media/views/button.js.

Follow-up to [22027], [31373].

Props ankitkumarshah, dhruvang21, getsyash.
Fixes #63422.

​@ankitkumarshah commented on ​PR #8788:
11 months ago #5

Merged in changeset: 60229

Note: See TracTickets for help on using tickets.