Opened 7 weeks ago
Last modified 7 weeks ago
#63423 new defect (bug)
Find some Wrong escaping function into the core files
Reported by: |
|
Owned by: | |
---|---|---|---|
Milestone: | Awaiting Review | Priority: | normal |
Severity: | normal | Version: | |
Component: | Media | Keywords: | dev-feedback has-patch changes-requested |
Focuses: | coding-standards | Cc: |
Description
Hello team,
I have checked WordPress core file and I have found this "Wrong escaping function" errors into the few files.
I think that it should be fix.
Thanks,
Attachments (2)
Change History (7)
#1
@
7 weeks ago
- Keywords has-patch added
@viralsampat Thank you for the ticket and patch. patch look good to me.
#2
@
7 weeks ago
- Keywords 2nd-opinion needs-testing removed
@viralsampat
Thanks for the patch
As a rule of thumb, please don't add needs-testing
keyword to Coding Standards tickets
Instead, post a link to this report #63168
And they will be merged pretty fast
#3
@
7 weeks ago
- Component changed from General to Media
- Version trunk deleted
The commit message for [54243] notes that it intentionally "includes a less-common use of esc_attr
for a textarea
." Maybe it is worth adding a comment within the code (cc: @joedolson).
I did not find an explanation for choosing esc_attr
on #41474, but a similar download link in the media list table uses esc_url
.
I have checked above mentioned issue and I have resolved it and added patch.