Make WordPress Core

Opened 7 weeks ago

Last modified 7 weeks ago

#63423 new defect (bug)

Find some Wrong escaping function into the core files

Reported by: viralsampat's profile viralsampat Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version:
Component: Media Keywords: dev-feedback has-patch changes-requested
Focuses: coding-standards Cc:

Description

Hello team,

I have checked WordPress core file and I have found this "Wrong escaping function" errors into the few files.

I think that it should be fix.

Thanks,

Attachments (2)

63423.patch (1.3 KB) - added by viralsampat 7 weeks ago.
I have checked above mentioned issue and I have resolved it and added patch.
63423.2.patch (748 bytes) - added by viralsampat 11 days ago.
I have checked above mentioned issue and founds few file. Here, I have added its patch.

Download all attachments as: .zip

Change History (7)

@viralsampat
7 weeks ago

I have checked above mentioned issue and I have resolved it and added patch.

#1 @dilipbheda
7 weeks ago

  • Keywords has-patch added

@viralsampat Thank you for the ticket and patch. patch look good to me.

#2 @SirLouen
7 weeks ago

  • Keywords 2nd-opinion needs-testing removed

@viralsampat
Thanks for the patch
As a rule of thumb, please don't add needs-testing keyword to Coding Standards tickets
Instead, post a link to this report #63168
And they will be merged pretty fast

#3 @sabernhardt
7 weeks ago

  • Component changed from General to Media
  • Version trunk deleted

The commit message for [54243] notes that it intentionally "includes a less-common use of esc_attr for a textarea." Maybe it is worth adding a comment within the code (cc: @joedolson).

I did not find an explanation for choosing esc_attr on #41474, but a similar download link in the media list table uses esc_url.

#4 @joedolson
7 weeks ago

Agreed; adding a comment to explain the unexpected usage makes sense. I think the commit message gives a good explanation, so that can be used as a basis for a code comment.

#5 @sabernhardt
7 weeks ago

  • Keywords changes-requested added

@viralsampat
11 days ago

I have checked above mentioned issue and founds few file. Here, I have added its patch.

Note: See TracTickets for help on using tickets.