Opened 12 months ago
Closed 10 months ago
#63424 closed defect (bug) (fixed)
Twenty Sixteen: Quote block Plain style has border in the editor
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Milestone: | 6.8.2 | Priority: | normal |
| Severity: | normal | Version: | 6.7 |
| Component: | Bundled Theme | Keywords: | has-patch has-screenshots has-test-info |
| Focuses: | Cc: |
Description
Steps to reproduce the issue:-
- Activate Twenty Sixteen theme.
- Choose Quote block.
- Add some text.
- Now choose styles plain.
You can able to see no borders when plain is chosen in front side, but editor side there is no difference even when plain is used from styles.
Attachments (2)
Change History (19)
#2
@
12 months ago
- Keywords changes-requested added
- Milestone changed from Awaiting Review to 6.9
- Summary changed from Twenty Sixteen - Quote block having issue in editor style when plain is choosen. to Twenty Sixteen: Quote block Plain style has border in the editor
- Version changed from 6.8 to 6.7
GB64045 introduced :where() in the Quote block's theme.css, and then Twenty Sixteen's editor-blocks.css overrode the Plain style with default border styles.
Instead of adding the .editor-styles-wrapper class with :where(), one to raise specificity and one to lower it, I recommend
.wp-block-quote.is-style-plain {
border: none;
}
#3
@
12 months ago
Test Report
Description
This report validates whether the indicated patch works as expected.
Patch tested: https://core.trac.wordpress.org/attachment/ticket/63424/63424.2.patch
Environment
- WordPress: 6.9-alpha-60093-src
- PHP: 8.2.28
- Server: nginx/1.27.5
- Database: mysqli (Server: 8.4.5 / Client: mysqlnd 8.2.28)
- Browser: Chrome 135.0.0.0
- OS: macOS
- Theme: Twenty Sixteen 3.5
- MU Plugins: None activated
- Plugins: Test Reports 1.2.0
Actual Results
✅ Issue resolved with patch.
Supplemental Artifacts
Before:
https://ibb.co/kg78SmSp
After:
https://ibb.co/tMHKDVjz
#5
@
12 months ago
I did not think about the possibility of using border-width: 0; earlier. If someone chooses the Plain style, border: none should be what they want. However, if Twenty Sixteen adds support for border options, border-width could allow adding a border even with the Plain style. (That decision could be part of the border options ticket instead.)
Anyway, 63424.2.patch works.
#6
@
11 months ago
Test Report
Description
This report validates whether the indicated patch works as expected.
Patch tested: https://core.trac.wordpress.org/attachment/ticket/63424/63424.2.patch
Environment
- WordPress: 6.9-alpha-60093-src
- PHP: 8.2.22
- Server: nginx/1.27.0
- Database: mysqli (Server: 8.0.39 / Client: mysqlnd 8.2.22)
- Browser: Chrome 136.0.0.0
- OS: Linux
- Theme: Twenty Ten 4.4
- MU Plugins: None activated
- Plugins:
- Test Reports 1.2.0
Actual Results
- ✅ Issue resolved with patch.
#7
follow-up:
↓ 8
@
11 months ago
- Keywords has-screenshots added
Test Report
This report validates that the indicated patch addresses the issue.
Patch tested: https://core.trac.wordpress.org/attachment/ticket/63424/63424.patch
Environment
OS: Windows
PHP: 8.2.28
WordPress: 6.9-alpha-60093-src
Browser: Chrome
Theme: Twenty Sixteen
Plugins: None activated
Actual Results:
✅ Before patch: Has border in the editor
Backend: https://prnt.sc/bqsv0UId57bP
Frontend: https://prnt.sc/ojxJHOGoQRJC
✅ After patch: Border removed in the editor
Backend: https://prnt.sc/LuKwAZoIgbE-
Frontend: https://prnt.sc/A53ACFqRW_iI
#8
in reply to:
↑ 7
@
11 months ago
- Keywords has-test-info added
Replying to harshgajipara:
This report validates that the indicated patch addresses the issue.
You have tested the wrong patch
Moreover, this report doesn't have needs-testing. No need for more tests.
If you are looking to find quality testing reports, come to Slack #core-test and we will advise on how to find.
#9
@
11 months ago
Test Report
Patch tested: https://core.trac.wordpress.org/attachment/ticket/63424/63424.2.patch
Environment:
OS: Windows
PHP: 8.2.28
WordPress: 6.9-alpha-60093-src
Browser: Chrome
Theme: Twenty Sixteen
Plugins: None activated
Actual Results:
✅ Before patch:
Backend: https://prnt.sc/aW5G2GPMw3my
Frontend: https://prnt.sc/ytvS0nG3NjM9
✅ After patch:
Backend: https://prnt.sc/yTostAEy7WNY
Frontend: https://prnt.sc/ZvOgFtfxEWN_
✅ Patch is working well as per desired solution
#10
@
11 months ago
- Keywords commit added
- Milestone changed from 6.9 to 6.8.2
Assigning to myself to testing so I can then look to commit if that works because it has passed tests.
#13
@
10 months ago
- Keywords commit removed
- Resolution fixed deleted
- Status changed from closed to reopened
Reopening for backport consideration.
Test Report
Description
This report validates whether the indicated patch works as expected.
Patch tested: https://core.trac.wordpress.org/attachment/ticket/63424/63424.patch
Environment
Actual Results