Make WordPress Core

Opened 5 weeks ago

Last modified 10 days ago

#63424 new defect (bug)

Twenty Sixteen: Quote block Plain style has border in the editor

Reported by: nidhidhandhukiya's profile nidhidhandhukiya Owned by:
Milestone: 6.9 Priority: normal
Severity: normal Version: 6.7
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:

Description

Steps to reproduce the issue:-

  1. Activate Twenty Sixteen theme.
  2. Choose Quote block.
  3. Add some text.
  4. Now choose styles plain.

You can able to see no borders when plain is chosen in front side, but editor side there is no difference even when plain is used from styles.

Attachments (2)

63424.patch (566 bytes) - added by nidhidhandhukiya 5 weeks ago.
63424.2.patch (541 bytes) - added by dilipbheda 5 weeks ago.
Updated patch file

Download all attachments as: .zip

Change History (8)

#1 @dilipbheda
5 weeks ago

  • Keywords has-patch added

Test Report

Description

This report validates whether the indicated patch works as expected.

Patch tested: https://core.trac.wordpress.org/attachment/ticket/63424/63424.patch

Environment

  • WordPress: 6.9-alpha-60093-src
  • PHP: 8.2.28
  • Server: nginx/1.27.5
  • Database: mysqli (Server: 8.4.5 / Client: mysqlnd 8.2.28)
  • Browser: Chrome 136.0.0.0
  • OS: Linux
  • Theme: Twenty Sixteen 3.5
  • MU Plugins: None activated
  • Plugins:
    • Test Reports 1.2.0

Actual Results

  1. ✅ Issue resolved with patch.

#2 @sabernhardt
5 weeks ago

  • Keywords changes-requested added
  • Milestone changed from Awaiting Review to 6.9
  • Summary changed from Twenty Sixteen - Quote block having issue in editor style when plain is choosen. to Twenty Sixteen: Quote block Plain style has border in the editor
  • Version changed from 6.8 to 6.7

GB64045 introduced :where() in the Quote block's theme.css, and then Twenty Sixteen's editor-blocks.css overrode the Plain style with default border styles.

Instead of adding the .editor-styles-wrapper class with :where(), one to raise specificity and one to lower it, I recommend

.wp-block-quote.is-style-plain {
	border: none;
}

@dilipbheda
5 weeks ago

Updated patch file

#3 @sainathpoojary
4 weeks ago

Test Report

Description

This report validates whether the indicated patch works as expected.

Patch tested: https://core.trac.wordpress.org/attachment/ticket/63424/63424.2.patch

Environment

  • WordPress: 6.9-alpha-60093-src
  • PHP: 8.2.28
  • Server: nginx/1.27.5
  • Database: mysqli (Server: 8.4.5 / Client: mysqlnd 8.2.28)
  • Browser: Chrome 135.0.0.0
  • OS: macOS
  • Theme: Twenty Sixteen 3.5
  • MU Plugins: None activated
  • Plugins: Test Reports 1.2.0

Actual Results

✅ Issue resolved with patch.

Supplemental Artifacts

Before:
https://ibb.co/kg78SmSp

After:
https://ibb.co/tMHKDVjz

#4 @sabernhardt
4 weeks ago

  • Keywords changes-requested removed

#5 @sabernhardt
4 weeks ago

I did not think about the possibility of using border-width: 0; earlier. If someone chooses the Plain style, border: none should be what they want. However, if Twenty Sixteen adds support for border options, border-width could allow adding a border even with the Plain style. (That decision could be part of the border options ticket instead.)

Anyway, 63424.2.patch works.

#6 @dhruvang21
10 days ago

Test Report

Description

This report validates whether the indicated patch works as expected.

Patch tested: https://core.trac.wordpress.org/attachment/ticket/63424/63424.2.patch

Environment

  • WordPress: 6.9-alpha-60093-src
  • PHP: 8.2.22
  • Server: nginx/1.27.0
  • Database: mysqli (Server: 8.0.39 / Client: mysqlnd 8.2.22)
  • Browser: Chrome 136.0.0.0
  • OS: Linux
  • Theme: Twenty Ten 4.4
  • MU Plugins: None activated
  • Plugins:
    • Test Reports 1.2.0

Actual Results

  1. ✅ Issue resolved with patch.
Note: See TracTickets for help on using tickets.