Adding custom field: wording and behaviour

[versuchsanstalt]

Adding custom fields has changed with 2.5rc1.

It seems impossible now to add more than one custom field before saving the post.

Clicking "Add Custom Field" does NOT (only) what the button says, but will also save the post. Either the wording is wrong or the behaviour.

Please bring back the 2.3.3 behaviour. I am developing a site where every post is just one or two sentences and two, sometimes three custom fields. It used to take about 20-30 seconds to write a post using 2.3.3, now its turning into a clickfest.

One or two more form elements for adding custom fields would also solve my problem, but the old way to do it used to be far better than that. I am considering to stay with 2.3.3.

[ryan]

Looks like the Add Custom Field AJAX is busted.

[mdawaffe]

I'll have a patch for this by Saturday afternoon PST.

[mdawaffe]

6343.diff

1. Fixes custom field add/update/delete.
2. Uses autosave functions after adding a custom field to a never-before-saved post to update post id.
3. Fixes strange wp-lists animation bug.

   jQuery( ... ).stop(); // doesn't work
   jQuery( ... ).stop().stop(); // does
   

[ryan]

Working well here. I notice that after adding a meta key to a new post, if you add title text and then change focus to another field the autosave on title blur doesn't kick in. Not a big deal.

[ryan]

(In [7468]) Fix custom field add/update/delete. Props mdawaffe. fixes #6343

[DD32]

Adding new meta keys when no meta keys currently exist is broken after the commit.

Upon clicking add, I get several PHP errors, To me, it looks like its not taking the correct branch.

Heres the post data:

array
  '_ajax_nonce' => string '92ea72e0e5' (length=10)
  'action' => string 'add-meta' (length=8)
  'post_id' => string '136' (length=3)
  'metakeyinput' => string 'testkey' (length=7)
  'metavalue' => string 'testvalue' (length=9)

I'll attach a patch for what seems to be the correct behaviour & is working for me

[ryan]

(In [7509]) Fix addition of new meta keys when no meta keys currently exist. Props DD32. fixes #6343