WordPress.org
Get WordPress

Make WordPress Core

Opened 11 months ago

Closed 11 months ago

#63472 closed defect (bug) (fixed)

Untranslatable default menu name in classic menus

Reported by: sergeybiryukov's profile SergeyBiryukov Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 6.9 Priority: normal
Severity: normal Version: 4.5
Component: I18N Keywords: good-first-bug has-patch
Focuses: Cc:

Description

There's a conditional in wp-admin/nav-menus.php:

if ( $one_theme_location_no_menus ) {
	$menu_name_val = 'value="' . esc_attr( 'Menu 1' ) . '"';
	...
}

esc_attr__() should be used instead to make the name translatable.

Introduced in [36379].

Change History (2)

This ticket was mentioned in ​PR #8828 on ​WordPress/wordpress-develop by ​@sainathpoojary.
11 months ago #1

  • Keywords has-patch added; needs-patch removed

Trac ticket: #63472

#2 @SergeyBiryukov
11 months ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 60245:

I18N: Make default menu name translatable on the Menus screen.

Follow-up to [36379].

Props sainathpoojary, SergeyBiryukov.
Fixes #63472.

Note: See TracTickets for help on using tickets.