Widget titles can be repetitive

[mdawaffe]

If you add a new widget, you'll often get a repetitive title in the admin.

Meta: Meta

We should test for this duplication and nip it in the bud.

(In [7467]) Don't dupe widget titles. Fixes #6349. Hat tip: mdawaffe.

Shouldn't the patch be this?

if ( $widget_title && $widget_title != $sidebar_args['widget_name'] )

The original patch fixes it for the default plugins, but it's still possible to get the repetitive title bug if $widget_title != $control['name'] but $widget_title == sidebar_args['widget_name'], which it does with what I'm doing.

Hm... Actually - I think the references in those few lines to $sidebar_args['widget_name'] are incorrect; they should reference $control['name'], shouldn't they?

When are those two different?

Replying to mdawaffe:

When are those two different?

They are different with the dashboard widgets apparently.

My plugin which results in the double titles: ​http://files.viper007bond.com/wordpress/dashboard-widget-manager_1.0.0beta.zip

We're comparing variables A and B and then displaying variables A and C. We should either compare A and C or display A and B, i.e compare and display the same variables.

It looks like we're displaying the widget name everywhere rather than the widget control name. This is probably an oversight, but it's too late to change for 2.5 now.

Attached makes everything consistent by using the widget name.

6349.c.diff incorporates all of 6349.b.diff and fixes a bug when adding new multi-widgets (extant titles were erroneously being appended to new instances of multi-widgets).

5823.a.diff on #5823 incorporates 6349.c.diff

(In [7725]) Tweak unused widgets interface. Make widget titles less repetitive. fixes #6349 #5823 for 2.5

(In [7726]) Tweak unused widgets interface. Make widget titles less repetitive. fixes #6349 #5823 for trunk