Make WordPress Core

Opened 8 weeks ago

Closed 8 weeks ago

#63491 closed defect (bug) (fixed)

Missing return type in public function parselisting( $line )

Reported by: opurockey's profile opurockey Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 6.9 Priority: normal
Severity: normal Version:
Component: Filesystem API Keywords: has-patch
Focuses: Cc:

Description

Hello

In wp-admin\includes\class-wp-filesystem-ftpext.php line: 664, It returns empty string but that return type is missing on function doc.

Please have a look. Thanks.

Attachments (1)

63491.patch (428 bytes) - added by opurockey 8 weeks ago.

Download all attachments as: .zip

Change History (4)

@opurockey
8 weeks ago

#1 @abcd95
8 weeks ago

  • Keywords has-patch added

Hi @opurockey, Thanks for the ticket.

I can see that the empty string return statement was added in [45583] and the DocBlock was added in [55714], which apparently did not handle the return type of the function in the docblock.

#2 @SergeyBiryukov
8 weeks ago

  • Milestone changed from Awaiting Review to 6.9

#3 @SergeyBiryukov
8 weeks ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 60261:

Docs: Improve documentation for WP_Filesystem_FTPext::parselisting().

Includes:

  • Adding a summary for the method.
  • Documenting the $line parameter.
  • Documenting the case when an empty string is returned.

Follow-up to [7126], [30678], [55714].

Props opurockey, abcd95, SergeyBiryukov.
Fixes #63491.

Note: See TracTickets for help on using tickets.