Adjust deprecation note in WP_Community_Events::format_event_data_time()

[SergeyBiryukov]

There's a function call in WP_Community_Events::format_event_data_time():

_deprecated_function(
	__METHOD__,
	'5.5.2',
	'This is no longer used by core, and only kept for backward compatibility.'
);

However, _deprecated_function() does not support a custom string like that, so what this actually displays is:

Deprecated: Function format_event_data_time is <strong>deprecated</strong> since version 5.5.2! Use This is no longer used by core, and only kept for backward compatibility. instead.

Since the DocBlock already mentions that the method is unused:

@deprecated 5.6.0 No longer used in core.

I think we can just remove the third argument so that the default deprecation message is used:

Deprecated: Function format_event_data_time is <strong>deprecated</strong> since version 5.5.2 with no alternative available.

That would also be consistent with the ::maybe_log_events_response()​ method in the same class.

Alternatively, _doing_it_wrong() can be used instead, which does support a custom message.

Introduced in [49146].

In this PR Refactored the deprecated function call to use _doing_it_wrong() for better clarity and compatibility in WP_Community_Events::format_event_data_time()

Trac ticket: https://core.trac.wordpress.org/ticket/63511

[rollybueno]

If we use _doing_it_wrong(), wouldn't it be considered as having alternative?

[SirLouen]

Replying to rollybueno:

If we use _doing_it_wrong(), wouldn't it be considered as having alternative?

Replying to SergeyBiryukov:

Alternatively, _doing_it_wrong() can be used instead, which does support a custom message.

doing_it_wrong doesn't fit here.

And the deprecation informational text is 100% redundant, as the deprecation message is self-explanatory. It can be cleared with 0 trouble.

This can be shipped.

[SergeyBiryukov]

In 60273:

General: Adjust WP_Community_Events::format_event_data_time() deprecation.

_deprecated_function() does not support a custom message, which appears to be redundant here, as the method's DocBlock already indicates that it is unused as of WordPress 5.5.2.

Includes correcting the version in the @deprecated tag.

Follow-up to [49146], [49201].

Props dhruvik18, dhruvang21, rollybueno, SirLouen, SergeyBiryukov.
Fixes #63511.