Twenty Fourteen: Latest Comments block link color does not belong in Content Sidebar

[sabernhardt]

[51205] set the link color to white for the Latest Comments block within any widget area. That was good for the Primary Sidebar and Footer Widget Area with their dark backgrounds, but it does not fit the Content Sidebar.

Avoids adding white link text where the background color is white.

Trac 63520

Before patch: the text color for Latest Comments links matches the Content Sidebar background (without :hover or :focus).

With patch: the links are green in the Content Sidebar, but they remain white against a dark background in the Primary and Footer sidebars.

[dhruvang21]

Test Report

Description

This report validates that the indicated patch works as expected.

Patch tested: ​https://patch-diff.githubusercontent.com/raw/WordPress/wordpress-develop/pull/8888.diff

Environment

• WordPress: 6.9-alpha-60093-src
• PHP: 8.2.22
• Server: nginx/1.27.0
• Database: mysqli (Server: 8.0.39 / Client: mysqlnd 8.2.22)
• Browser: Chrome 136.0.0.0
• OS: Linux
• Theme: Twenty Fourteen 4.2
• MU Plugins: None activated
• Plugins:
  • Test Reports 1.2.0

Actual Results

1. ✅ Issue resolved with patch.

Supplemental Artifacts

Added as Attachment

[dhruvang21]

Before patch

[ravigadhiyawp]

Reproduction Report

Description

This report validates whether the issue can be reproduced.

Environment

• WordPress: 6.8.1
• PHP: 8.2.23
• Server: nginx/1.26.1
• Database: mysqli (Server: 8.0.35 / Client: mysqlnd 8.2.23)
• Browser: Chrome 137.0.0.0
• OS: Windows 10/11
• Theme: Twenty Fourteen 4.2
• MU Plugins: None activated
• Plugins:
  • Test Reports 1.2.0

Actual Results

1. ✅ Error condition occurs (reproduced).

Additional Notes

Steps to reproduce the issue:

• Add 'recent comment widget' in Primary Sidebar, Footer Widget Sidebar & Content Sidebar from Appearance > Widgets
• Now visit the front blog listing and blog detail page. You can see that 'Comment Author' name text and Post Title text are now showing in Content Sidebar because it have white background color.
• Those are showing properly in Primary Sidebar and Footer Widget Sidebar.

Supplemental Artifacts

Screenshot: ​https://prnt.sc/6sIJaaA1frC-

[ravigadhiyawp]

Test Report

Description

This report validates whether the indicated patch works as expected.

Patch tested: ​https://patch-diff.githubusercontent.com/raw/WordPress/wordpress-develop/pull/8888.diff

Environment

• WordPress: 6.8.1
• PHP: 8.2.23
• Server: nginx/1.26.1
• Database: mysqli (Server: 8.0.35 / Client: mysqlnd 8.2.23)
• Browser: Chrome 137.0.0.0
• OS: Windows 10/11
• Theme: Twenty Fourteen 4.2
• MU Plugins: None activated
• Plugins:
  • Test Reports 1.2.0

Actual Results

1. ✅ Issue resolved with patch.

Additional Notes

• This css patch is working fine.

Supplemental Artifacts

Screenshot: ​https://prnt.sc/uhu0QTAGmpna

[sabernhardt]

I think assigning the color only to the Primary and Footer widget areas would have been a better choice four years ago, when blocks were introduced to widgets.

.primary-sidebar .wp-block-latest-comments__comment-meta a,
.footer-sidebar .wp-block-latest-comments__comment-meta a {
	color: #fff;
}

However, a site with a child theme can register an extra widget area. For that situation, PR 8888 expects that any custom sidebar is against a dark background, does not include a Latest Comments widget, and/or already has custom styles to fix the text color. The patch only excludes the Content Sidebar:

.widget-area:where(:not(.content-sidebar)) .wp-block-latest-comments__comment-meta a {
	color: #fff;
}

[sandeepdahiya]

Before applying the patch

[sandeepdahiya]

After applying the patch

[sandeepdahiya]

Test Report

This report validates that the indicated patch addresses the issue.
Patch tested: ​https://patch-diff.githubusercontent.com/raw/WordPress/wordpress-develop/pull/8888.diff

Environment

• OS: Windows 11 Home
• Web Server: Nginx 1.27.5
• PHP: 8.2.28
• WordPress: 6.9-alpha-60093-src
• Browser: Mozilla Firefox 139.0.1 (Latest)
• Theme: Twenty Fourteen
• Active Plugins:
  • Code Snippets 3.6.8
  • WordPress Beta Tester 3.6.3

Actual Results

• ✅ Issue resolved with patch – color in content sidebar is green as mentioned.

Additional Notes

• Kindly refer attached images for before and after screenshots.

Test Report
This report validates that the indicated patch addresses the issue.
Patch tested: ​https://patch-diff.githubusercontent.com/raw/WordPress/wordpress-develop/pull/8888.diff
Environment

• OS: Windows 11 Home
• Web Server: Nginx 1.27.5
• PHP: 8.2.28
• WordPress: 6.9-alpha-60093-src
• Browser: Mozilla Firefox 139.0.1 (Latest)
• Theme: Twenty Fourteen
• Active Plugins:
• - Code Snippets 3.6.8
• - WordPress Beta Tester 3.6.3

Actual Results

• ✅ Issue resolved with patch – color in content sidebar is green as mentioned.

Additional Notes

• Kindly refer attached images for before patch and after patch results.

Before applying patch: -

After applying patch: -

[karmatosed]

Assigning to myself to follow through and see about commit.

[karmatosed]

In 60368:

Twenty Fourteen: Fixes Latest Comment Link Color in Content Sidebar.

The white link text had worked against the dark background of the Primary and Footer widget areas, but not against the light background in the Content Sidebar. Therefore, r60368 excludes the Content Sidebar from that ruleset.

Props sabernhardt, dhruvang21, ravigadhiyawp, sandeepdahiya.
Fixes #63520.

[sabernhardt]

Reopening for backport consideration.

[audrasjb]

In 60425:

Twenty Fourteen: Fixes Latest Comment Link Color in Content Sidebar.

The white link text had worked against the dark background of the Primary and Footer widget areas, but not against the light background in the Content Sidebar. Therefore, r60368 excludes the Content Sidebar from that ruleset.

Reviewed by audrasjb.
Merges [60368] to the 6.8 branch.
Props sabernhardt, dhruvang21, ravigadhiyawp, sandeepdahiya.
Fixes #63520.