Make WordPress Core

Opened 11 months ago

Closed 10 months ago

Last modified 7 months ago

#63533 closed enhancement (wontfix)

Update "Call to Action" to "Call to action"

Reported by: juanfra's profile juanfra Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch changes-requested 2nd-opinion close
Focuses: Cc:

Description

This ticket is a follow-up of https://core.trac.wordpress.org/ticket/62414#comment:4

We're updating "Call to Action" to "Call to action" everywhere for consistency.

Change History (10)

This ticket was mentioned in PR #8905 on WordPress/wordpress-develop by @juanfra.


11 months ago
#1

  • Keywords has-patch added

Trac ticket: https://core.trac.wordpress.org/ticket/63533

Updating "Call to Action" to "Call to action" using sentence case, for consistency. Follow-up of https://core.trac.wordpress.org/ticket/62414#comment:4

#2 @rollybueno
11 months ago

Reproduction Report

Description

This report validates whether the issue can be reproduced for the 2020 Theme.

Environment

  • WordPress: 6.8.1
  • PHP: 8.2.27
  • Server: nginx/1.26.1
  • Database: mysqli (Server: 8.0.35 / Client: mysqlnd 8.2.27)
  • Browser: Chrome 136.0.0.0
  • OS: Linux
  • Theme: Twenty Twenty 2.9
  • MU Plugins: None activated
  • Plugins:
    • Query Monitor 3.17.2
    • Test Reports 1.2.0
    • User Switching 1.9.2
    • WordPress Beta Tester 3.6.3

Actual Results

  1. ✅ Error condition occurs (reproduced).

Supplemental Artifacts

https://i.imgur.com/Ecjqgz8.png

#3 @rollybueno
11 months ago

Test Report

Description

This report validates whether the indicated patch works as expected. Please see the Additonal Notes.

Patch tested: https://patch-diff.githubusercontent.com/raw/WordPress/wordpress-develop/pull/8905.diff

Environment

  • WordPress: 6.8.1
  • PHP: 8.2.27
  • Server: nginx/1.26.1
  • Database: mysqli (Server: 8.0.35 / Client: mysqlnd 8.2.27)
  • Browser: Chrome 136.0.0.0
  • OS: Linux
  • Theme: Twenty Twenty 2.9
  • MU Plugins: None activated
  • Plugins:
    • Query Monitor 3.17.2
    • Test Reports 1.2.0
    • User Switching 1.9.2
    • WordPress Beta Tester 3.6.3

Actual Results

  1. ✅ Issue resolved with patch.

Additional Notes

  • Worth noting here. If you have already saved Call to action block prior to the 2020 patch, the block name stucked on Call to Action because it's saved in DB. See the screenshot below.

https://i.imgur.com/fIZtIw4.png

Supplemental Artifacts

Patch will work when you add the block as new. Existing one prior to update stucked on Call to Action as mentioned above with screenshot.

https://i.imgur.com/gwbxNwj.png

#4 @SergeyBiryukov
11 months ago

  • Component changed from Themes to Bundled Theme
  • Keywords changes-requested added
  • Milestone changed from Awaiting Review to 6.9

Hi there, thanks for the ticket!

Looking at other block pattern titles in these themes, they seem to have a mix of sentence case and title case, so could probably use a few more adjustments:

  • Twenty Sixteen:
    • Large heading with short description
    • Big Title with Two Columns Text
    • Large Blockquote
    • Call to action (with the patch)
  • Twenty Twenty
    • Call to action (with the patch)
    • Double Call to action (with the patch; should probably be “Double call to action”?)
    • Event Details
    • Featured Content
    • Introduction

Should these titles all be in sentence case for consistency?

#5 @sabernhardt
11 months ago

  • Keywords 2nd-opinion added

As I said in ticket:50773#comment:36,

Please do not update translatable strings in themes to reflect the common letter case in the administration area.

Keeping the letter case consistent within each theme is more important.

Twenty Twenty-Four capitalizes Action in the context part of only one call-to-action string, but only translators should see the context. I do not recommend changing any of those now.

  • Call to Action button text context for the 'About us' string
  • Call to action button text for the reservation button context for the 'Reserve your spot' string
  • RSVP call to action description context for the 'Experience the fusion of imagination and expertise with Études Arch Summit, February 2025.' string
  • 'Centered call to action' pattern title
  • 'Services call to action with image on left' pattern title
  • Ten of the pattern descriptions include the CTA abbreviation (which gives more value to capitalizing Action, but I would not update all the others).

Twenty Twenty uses title case for all five of its pattern titles.

  • Call to Action
  • Double Call to Action
  • Event Details
  • Featured Content
  • Introduction

Twenty Sixteen uses title case for three out of four pattern titles.

  • Large heading with short description
  • Big Title with Two Columns Text
  • Large Blockquote
  • Call to Action
Last edited 11 months ago by sabernhardt (previous) (diff)

#6 @juanfra
11 months ago

Thank you all for looking at this.

Looking at other block pattern titles in these themes, they seem to have a mix of sentence case and title case, so could probably use a few more adjustments. Should these titles all be in sentence case for consistency?

Yes. I believe we should do it when strings are in the blocks editor context. If there's agreement on this I can add the changes.

Keeping the letter case consistent within each theme is more important.

While I agree that consistency within each theme is important, I think it’s also worth considering the context here. These strings appear within the block editor, where sentence case is already the standard. So in this particular case, I believe it makes sense to go ahead with the fix.

For other cases, like those discussed in #50773, or strings that are part of pattern content or templates, I agree we should hold off.

#7 @sabernhardt
11 months ago

  • Type changed from defect (bug) to enhancement

Editing all the pattern titles for consistency with the editor interface would be a bigger project. I think updating those strings now would give polyglots too much extra work for little improvement.

  • T25, T24 and T21 already use sentence case for all of their block pattern titles.
  • T20, T17, T13, T12, T11 and T10 use title case for all of their pattern titles (24 of the 27 titles have more than one word).
  • T23 uses title case for 6 of its 7 pattern titles, and 'Call to action' is the one in sentence case.
  • T22 uses sentence case for its block pattern titles, but "Header" is still capitalized in 'Logo, navigation, and offset tagline Header' (if that is changed, I would suggest rearranging it to "Header with logo, navigation, and offset tagline").
  • T19's pattern titles capitalize every word, including "in" for the 'Get In Touch' pattern.
  • T16 uses title case for 3 of its 4 pattern titles, but 'Large heading with short description' (the longest title) is sentence case.
  • T15 also uses title case for 3 of its 4 pattern titles, but 'Contact area' is sentence case.
  • T14's pattern titles are only one word each, which counts as either title or sentence case.

#8 @karmatosed
10 months ago

  • Milestone changed from 6.9 to Awaiting Review

I tend to agree with this sentiment:

Editing all the pattern titles for consistency with the editor interface would be a bigger project. I think updating those strings now would give polyglots too much extra work for little improvement.

We have to think about the effort versus what we gain in these cases and I am personally not finding that balance but happy to be wrong. For now, as there isn't an agremenet I do not see this should be in next version, we need to either agree to do across more themes or we need to agree to leave it. My advice would be 'won't fix'. I say this because we have to consider effort, not to dismiss.

#9 @karmatosed
10 months ago

  • Keywords close added
  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from new to closed

As there is agreement and the close label has been there, let's move this to won't fix for now. Thank you everyone for collaboration on this. We can always reopen should more details emerge.

@juanfra commented on PR #8905:


7 months ago
#10

Closing as it was marked as wontfix on trac: https://core.trac.wordpress.org/ticket/63533

Note: See TracTickets for help on using tickets.