Make WordPress Core

Opened 5 weeks ago

Closed 5 weeks ago

Last modified 5 weeks ago

#63539 closed enhancement (duplicate)

wp_add_id3_tag_data() unit test coverage

Reported by: rollybueno's profile rollybueno Owned by:
Milestone: Priority: normal
Severity: normal Version: 6.8
Component: Build/Test Tools Keywords: needs-patch needs-unit-tests
Focuses: tests, sustainability Cc:

Description

Separating the discussions from https://core.trac.wordpress.org/ticket/63529,
wp_add_id3_tag_data() does not have a test unit coverage which would be great to have as per https://core.trac.wordpress.org/ticket/63529#comment:13

The test unit can go be inside tests/phpunit/tests/media

Change History (4)

#1 @ankitkumarshah
5 weeks ago

Hi @rollybueno,
Thank you for separating the issue — I’d be glad to help by working on the unit tests for it!
https://core.trac.wordpress.org/ticket/63529#comment:19

#2 @westonruter
5 weeks ago

  • Focuses performance removed

#3 @SirLouen
5 weeks ago

  • Resolution set to duplicate
  • Status changed from new to closed

@rollybueno
Why have you separated this?
It's better to ship patches with their respective unit tests all in one because this could end lost in oblivion, while a needs-unit-test in the original report can serve as a blocker to avoid this happening.
Can we move the work back to #63529?

#4 @johnbillion
5 weeks ago

  • Milestone Awaiting Review deleted
Note: See TracTickets for help on using tickets.