Context Navigation

Changes between Initial Version and Version 2 of Ticket #63576

Timestamp:

06/16/2025 07:25:13 PM (13 months ago)

Author:

sabernhardt

Comment:

(See line 742 on the GitHub repository if you want to create a pull request.)

The substr() function should always return a string. I think simply checking for an empty string would suffice: if ($body !== '')

-              initial
+              v2
 In limited circumstances, HTTP requests made using wp-includes/Requests/src/Requests.php will incorrectly return an empty string as the response body, even though the request executed and returned a value in the response.
+In limited circumstances, HTTP requests made using `wp-includes/Requests/src/Requests.php` will incorrectly return an empty string as the response body, even though the request executed and returned a value in the response.
 This happens when the returned value is PHP-falsey (for example, the string "0") - or in other words, when empty($value) evaluates to true in PHP.
+This happens when the returned value is PHP-falsey (for example, the string `"0"`) - or in other words, when `empty($value)` evaluates to true in PHP.
 I've encountered this issue in production, so the diff we went with is attached.