Make WordPress Core

Opened 5 months ago

Closed 6 weeks ago

Last modified 5 weeks ago

#63603 closed enhancement (fixed)

Replace deprecated / non-standard CSS for `speak` and `aural`

Reported by: krokodok's profile krokodok Owned by: joedolson's profile joedolson
Milestone: 6.9 Priority: normal
Severity: normal Version:
Component: General Keywords: has-patch reviewing
Focuses: accessibility, css Cc:

Description

Both speak: never and @media aural are deprecated and/or non-standard. They are exclusively used for font-icons on pseudo elements. We can replace them with the syntax content: "\icon-code" / "", which is widely supported.

Examples of files where this is used:
– …/src/wp-admin/css/common.css
– …/src/wp-admin/css/themes.css

Change History (13)

This ticket was mentioned in PR #9028 on WordPress/wordpress-develop by @krokodok.


5 months ago
#1

  • Keywords has-patch added

Both speak: never and @media aural are deprecated and/or non-standard. They are exclusively used for font-icons on pseudo elements. We can replace them with the syntax content: "\icon-code" / "", which is widely supported.

Trac ticket: [](https://core.trac.wordpress.org/ticket/63603#ticket)

#2 @krokodok
5 months ago

If you would suggest keeping speak: never for future support of CSS3 Speech Module, I can modify my PR to remove only @media aural, which hast not been part of the Draft any more for a long time.

#3 @sabernhardt
5 months ago

  • Version trunk deleted

Related: #40428

#4 @audrasjb
5 months ago

  • Keywords dev-feedback added
  • Milestone changed from Awaiting Review to 6.9
  • Owner set to audrasjb
  • Status changed from new to reviewing

Thank you for opening this issue, the proposed implementation looks good to me. As there is a detailed justification for this change and a functional patch, I'm moving this to 6.9, pending further review.

@joedolson commented on PR #9028:


5 months ago
#5

This will need a trac ticket to be considered for merge; are you planning on opening one, @krokodok?

@krokodok commented on PR #9028:


5 months ago
#6

@joedolson Made a mistake in the formatting of my initial post. There was a link to the ticket: https://core.trac.wordpress.org/ticket/63603

@krokodok commented on PR #9028:


2 months ago
#7

@joedolson Hey would you – or anybody else – have some time to look into this PR again? :)

This ticket was mentioned in Slack in #accessibility by joedolson. View the logs.


6 weeks ago

#9 @joedolson
6 weeks ago

  • Owner changed from audrasjb to joedolson
  • Status changed from reviewing to accepted

@joedolson commented on PR #9028:


6 weeks ago
#10

Following https://core.trac.wordpress.org/changeset/60806, this PR has a ton of merge conflicts. That was kind of inevitable; one of these would end up with a ton of conflicts, since they're touching a lot of the same areas. If you can handle the merge conflicts, that would be great, but let me know if not.

#11 @joedolson
6 weeks ago

  • Keywords reviewing added; dev-feedback removed

#12 @joedolson
6 weeks ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 60885:

General: A11y: Remove obsolete speak and aural CSS.

Remove instances of speak: never and @media aural, which are deprecated and/or non-standard CSS. These never had any broad browser support, but generated content alternatives do. See #40428.

Props krokodok, audrasjb, joedolson.
Fixes #63603.

@krokodok commented on PR #9028:


5 weeks ago
#13

Hey @joedolson , I was on vacation the last week, so I really appreciate you taking over for merging my PR. Thanks a lot!

Note: See TracTickets for help on using tickets.