Opened 5 months ago
Last modified 4 months ago
#63628 new enhancement
Build/Test Tools: Remove unnecessary `docker` branding
| Reported by: |
|
Owned by: | |
|---|---|---|---|
| Milestone: | Awaiting Review | Priority: | normal |
| Severity: | normal | Version: | trunk |
| Component: | Build/Test Tools | Keywords: | has-patch |
| Focuses: | coding-standards | Cc: |
Description
This PR brings following improvements:
- Add container repository (
docker.io) tocompose.yaml - Remove
docker-prefix -> more generic & prefix not needed - add "missing" container tags
Ref: https://github.com/WordPress/wordpress-develop/pull/9086
Change History (5)
This ticket was mentioned in PR #9086 on WordPress/wordpress-develop by @Ninos Ego.
5 months ago
#1
- Keywords has-patch added
#2
@
5 months ago
- Keywords reporter-feedback close added
What is the justification for these changes?
Why you consider them improvements? Are you against docker compose but a advocate of docker.io?
#3
@
5 months ago
- Component changed from General to Build/Test Tools
- Keywords reporter-feedback close removed
Thanks @ninos-ego!
I've added a review on the PR. The main push back there is that the one line change explicitly adding Podman as an option could require many more changes to documentation elsewhere across w.org.
A few other concerns after looking this over:
- Any contributor that currently has a
docker-compose.override.ymlfile locally will no longer see their overrides reflected within the environment. This is probably fine and we've made changes in the past that required action (sometimes even recreating the environment completely), but the timing of this change should be calculated and a developer note _may_ be appropriate. - One possible side effect of this change is that it becomes more difficult for newer contributors to find information on the Internet about how the file works. There are tons of tutorials and resources online that reference
docker-compose.yml. Not a blocker, but something we should consider!
Note: See
TracTickets for help on using
tickets.
This PR brings following improvements:
docker.io) tocompose.yamldocker-prefix -> more generic & prefix not neededTrac:
https://core.trac.wordpress.org/ticket/63628