#63629 closed defect (bug) (fixed)
I18N string improvements for 6.9
| Reported by: |
|
Owned by: | |
|---|---|---|---|
| Milestone: | 6.9 | Priority: | normal |
| Severity: | normal | Version: | |
| Component: | I18N | Keywords: | has-patch |
| Focuses: | Cc: |
Description
Opening this because of https://core.trac.wordpress.org/ticket/23311#comment:20 and I think it makes sense to have a catch-all ticket for i18n string improvements per milestone.
Attachments (1)
Change History (11)
This ticket was mentioned in PR #9204 on WordPress/wordpress-develop by @rollybueno.
6 months ago
#2
- Keywords has-patch added
### Fix capitalization in SMTP error message
Standardize "data not accepted" to "Data not accepted" for consistency with other SMTP error messages that use proper capitalization after the colon.
Trac ticket: https://core.trac.wordpress.org/ticket/63629
#3
@
6 months ago
- Keywords dev-feedback added
The "hostentry" update already reflected on trunk https://github.com/wordpress/wordpress-develop/blob/trunk/src/wp-includes/class-wp-phpmailer.php#L70, but I noticed that 1 string is not consistent in formatting. All "SMTP Error" message comes with uppercase on the first letter after the ":" but the data_not_accepted comes with lowercase.
Updated from:
'data_not_accepted' => __( 'SMTP Error: data not accepted.' )
To:
'data_not_accepted' => __( 'SMTP Error: Data not accepted.' )
So far, I can only see this one improvement we can add. cc @swissspidy.
PS: IMO, no need for testing since this is just a capitalisation update.
#6
follow-up:
↓ 8
@
5 months ago
I18N: Add translator comments and ensure consistent text domain usage for improved string translation in 6.9.
@SergeyBiryukov commented on PR #9204:
4 months ago
#7
Thanks for the PR! This was merged in r60419.
#8
in reply to:
↑ 6
@
4 months ago
Replying to sachinrajcp123:
I18N: Add translator comments and ensure consistent text domain usage for improved string translation in 6.9.
Thanks for the patch! It appears that the first instance already has a translator comment in trunk:
<strong><?php _e( 'Requires WordPress Version:' ); ?></strong> <?php /* translators: %s: Version number. */ printf( __( '%s or higher' ), $api->requires ); ?>
and the second one does not really need a comment, as it doesn't contain any translatable strings with placeholders:
$scripts->set_translations( 'password-strength-meter', 'default' );
In 60356: