Make WordPress Core

Opened 7 months ago

Closed 2 months ago

Last modified 2 months ago

#63629 closed defect (bug) (fixed)

I18N string improvements for 6.9

Reported by: swissspidy's profile swissspidy Owned by:
Milestone: 6.9 Priority: normal
Severity: normal Version:
Component: I18N Keywords: has-patch
Focuses: Cc:

Description

Opening this because of https://core.trac.wordpress.org/ticket/23311#comment:20 and I think it makes sense to have a catch-all ticket for i18n string improvements per milestone.

Attachments (1)

63629-i18n-string-improvements.diff (1.3 KB) - added by sachinrajcp123 5 months ago.

Download all attachments as: .zip

Change History (11)

#1 @swissspidy
7 months ago

In 60356:

I18N: Improve translatable string in WP_PHPMailer.

See [59592] / #23311.

Props GaryJ.
See #63629.

This ticket was mentioned in PR #9204 on WordPress/wordpress-develop by @rollybueno.


6 months ago
#2

  • Keywords has-patch added

### Fix capitalization in SMTP error message

Standardize "data not accepted" to "Data not accepted" for consistency with other SMTP error messages that use proper capitalization after the colon.

Trac ticket: https://core.trac.wordpress.org/ticket/63629

#3 @rollybueno
6 months ago

  • Keywords dev-feedback added

The "hostentry" update already reflected on trunk https://github.com/wordpress/wordpress-develop/blob/trunk/src/wp-includes/class-wp-phpmailer.php#L70, but I noticed that 1 string is not consistent in formatting. All "SMTP Error" message comes with uppercase on the first letter after the ":" but the data_not_accepted comes with lowercase.

Updated from:

'data_not_accepted'    => __( 'SMTP Error: data not accepted.' )

To:

'data_not_accepted'    => __( 'SMTP Error: Data not accepted.' )

So far, I can only see this one improvement we can add. cc @swissspidy.

PS: IMO, no need for testing since this is just a capitalisation update.

#4 @swissspidy
6 months ago

In 60419:

I18N: Improve string capitalization in WP_PHPMailer.

See [59592] / #23311.

Props rollybueno.
See #63629.

#5 @swissspidy
6 months ago

  • Keywords dev-feedback removed

#6 follow-up: @sachinrajcp123
5 months ago

I18N: Add translator comments and ensure consistent text domain usage for improved string translation in 6.9.

@SergeyBiryukov commented on PR #9204:


4 months ago
#7

Thanks for the PR! This was merged in r60419.

#8 in reply to: ↑ 6 @SergeyBiryukov
4 months ago

Replying to sachinrajcp123:

I18N: Add translator comments and ensure consistent text domain usage for improved string translation in 6.9.

Thanks for the patch! It appears that the first instance already has a translator comment in trunk:

<strong><?php _e( 'Requires WordPress Version:' ); ?></strong>
<?php
/* translators: %s: Version number. */
printf( __( '%s or higher' ), $api->requires );
?>

and the second one does not really need a comment, as it doesn't contain any translatable strings with placeholders:

$scripts->set_translations( 'password-strength-meter', 'default' );

#9 @wildworks
2 months ago

  • Resolution set to fixed
  • Status changed from new to closed

Since next week is RC1, which means string freeze, let's close this ticket. We may be able to submit a new ticket for 7.0.

#10 @desrosj
2 months ago

I've opened #64244 for the 7.0 release cycle.

Note: See TracTickets for help on using tickets.